Bugzilla – Attachment 22866 Details for
Bug 11183
Warnings in opac
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
bug_11183: Supress undef warning in opac-MARCdetail.pl
bug11183-Supress-undef-warning-in-opac-MARCdetailp.patch (text/plain), 1.49 KB, created by
Srdjan Jankovic
on 2013-11-12 07:59:10 UTC
(
hide
)
Description:
bug_11183: Supress undef warning in opac-MARCdetail.pl
Filename:
MIME Type:
Creator:
Srdjan Jankovic
Created:
2013-11-12 07:59:10 UTC
Size:
1.49 KB
patch
obsolete
>From e60894f9c6949a44b1ea882758d091caa8c434b8 Mon Sep 17 00:00:00 2001 >From: Srdjan <srdjan@catalyst.net.nz> >Date: Tue, 12 Nov 2013 20:53:39 +1300 >Subject: [PATCH] bug_11183: Supress undef warning in opac-MARCdetail.pl > >To test: >* Go to /cgi-bin/koha/opac-MARCdetail.pl?biblionumber=<your fav biblionumber> > and confirm that pre and post patch page looks the same. > >An apology: I tried to find a syspref combination that displays >opac-MARCdetail.pl links in OPAC search results, and failed. If anyone >knows, the secret combination, please disclose. I resorted to entering >the url by hand. >--- > opac/opac-MARCdetail.pl | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > >diff --git a/opac/opac-MARCdetail.pl b/opac/opac-MARCdetail.pl >index d6be0a6..aa72a3e 100755 >--- a/opac/opac-MARCdetail.pl >+++ b/opac/opac-MARCdetail.pl >@@ -176,8 +176,9 @@ for ( my $tabloop = 0 ; $tabloop <= 9 ; $tabloop++ ) { > next if ( ($sf_def->{tab}||0) != $tabloop ); > next if ( ($sf_def->{hidden}||0) > 0 ); > my %subfield_data; >- $subfield_data{marc_lib} = ($sf_def->{lib} eq $previous) ? '--' : $sf_def->{lib}; >- $previous = $sf_def->{lib}; >+ my $lib = $sf_def->{lib} // ''; >+ $subfield_data{marc_lib} = ($lib eq $previous) ? '--' : $sf_def->{lib}; >+ $previous = $lib; > $subfield_data{link} = $sf_def->{link}; > $subf[$i][1] =~ s/\n/<br\/>/g; > if ( $sf_def->{isurl} ) { >-- >1.8.1.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11183
:
22663
|
22794
|
22801
|
22810
|
22839
|
22853
|
22855
|
22856
|
22857
|
22862
|
22866
|
22867
|
23095
|
23096
|
23097