From 1f9f3e25a2809bcab0f4d5f12418fc41335a3288 Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Wed, 13 Nov 2013 13:41:15 -0300 Subject: [PATCH] Bug 10663: (3.12.x followup) Rewrite some calls as unit tests rely on newer API MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Some tests fail in t/db_dependent/Circulation.t because of API difference. This patch is a followup for 3.12.x. Regards To+ Sponsored-by: Universidad Nacional de Córdoba --- t/db_dependent/Circulation.t | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t index bf27fb5..97c07bf 100755 --- a/t/db_dependent/Circulation.t +++ b/t/db_dependent/Circulation.t @@ -242,8 +242,7 @@ C4::Context->dbh->do("DELETE FROM borrowers WHERE cardnumber = '99999999999'"); is( $renewokay, 0, '(Bug 10663) Cannot renew, reserved'); is( $error, 'on_reserve', '(Bug 10663) Cannot renew, reserved (returned error is on_reserve)'); - my $reserveid = C4::Reserves::GetReserveId({ biblionumber => $biblionumber, borrowernumber => $reserving_borrowernumber}); - CancelReserve({ reserve_id => $reserveid }); + CancelReserve( $biblionumber, undef, $reserving_borrowernumber ); diag("Item-level hold, renewal test"); @@ -269,8 +268,7 @@ C4::Context->dbh->do("DELETE FROM borrowers WHERE cardnumber = '99999999999'"); # FIXME: Add more for itemtype not for loan etc. - $reserveid = C4::Reserves::GetReserveId({ biblionumber => $biblionumber, itemnumber => $itemnumber, borrowernumber => $reserving_borrowernumber}); - CancelReserve({ reserve_id => $reserveid }); + CancelReserve( $biblionumber, $itemnumber, $reserving_borrowernumber ); diag("Too many renewals"); -- 1.8.4.2