Bugzilla – Attachment 2300 Details for
Bug 4932
Serial Enumeration / chronology not always populated when receiving new issue
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed fix
0001-Fix-for-Bug-4932-Serial-Enumeration-chronology-not-p.patch (text/plain), 4.48 KB, created by
Owen Leonard
on 2010-07-02 14:04:08 UTC
(
hide
)
Description:
Proposed fix
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2010-07-02 14:04:08 UTC
Size:
4.48 KB
patch
obsolete
>From 1f764d39fb14a935b1af9b39469268c7c2500cff Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 2 Jul 2010 09:44:30 -0400 >Subject: [PATCH] Fix for Bug 4932, Serial Enumeration / chronology not populated on receive > >- Correcting JavaScript so that serial enumeration / chronology is always > prepopulated in the add item form when receiving a new issue. >- Altering the behavior of the "click to add item" link so that the > "Arrived" option is automatically selected. This makes the link's > behavior mirror the <select>'s behavior so that Arrived -> Add item > and Add item -> Arrived. >--- > .../prog/en/modules/serials/serials-edit.tmpl | 7 +++++-- > 1 files changed, 5 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tmpl >index dd73db9..8805654 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tmpl >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tmpl >@@ -81,6 +81,9 @@ function HideItems(index,labelindex) { > label = document.getElementById(labelindex); > label.style.display='block'; > } >+function setStatus(serialid){ >+ $("#status"+serialid).val("2").attr("selected","selected"); >+} > function changeDate(adate) { > var elem = document.getElementById("expecteddate"); > elem.value = adate; >@@ -224,7 +227,7 @@ function CloneSubfield(index){ > <select name="status" size="1" disabled="disabled"> > <!--TMPL_ELSE--> > <!--TMPL_IF Name="serialsadditems"--> >- <select name="status" size="1" id="status<!-- TMPL_VAR NAME="serialid" -->" onchange="if (this.value==2){unHideItems('items'+<!-- TMPL_VAR NAME="subscriptionid" -->+<!-- TMPL_VAR NAME="serialid" -->,'label<!-- TMPL_VAR NAME="subscriptionid" --><!--TMPL_VAR Name="serialid"-->'); changeDate('<!-- TMPL_VAR NAME="arriveddate" -->')} else if (this.value==7){changeDate('<!-- TMPL_VAR NAME="arriveddate" -->')} else { HideItems('items'+<!-- TMPL_VAR NAME="subscriptionid" -->+<!-- TMPL_VAR NAME="serialid" -->,'label<!-- TMPL_VAR NAME="subscriptionid" --><!--TMPL_VAR Name="serialid"-->'); changeDate('<!-- TMPL_VAR NAME="planneddate" -->')}" > >+ <select name="status" size="1" id="status<!-- TMPL_VAR NAME="serialid" -->" onchange="if (this.value==2){unHideItems('items'+<!-- TMPL_VAR NAME="subscriptionid" --><!-- TMPL_VAR NAME="serialid" -->,'label<!-- TMPL_VAR NAME="subscriptionid" --><!--TMPL_VAR Name="serialid"-->','<!-- TMPL_VAR NAME="serialid" -->'); changeDate('<!-- TMPL_VAR NAME="arriveddate" -->')} else if (this.value==7){changeDate('<!-- TMPL_VAR NAME="arriveddate" -->')} else { HideItems('items'+<!-- TMPL_VAR NAME="subscriptionid" -->+<!-- TMPL_VAR NAME="serialid" -->,'label<!-- TMPL_VAR NAME="subscriptionid" --><!--TMPL_VAR Name="serialid"-->'); changeDate('<!-- TMPL_VAR NAME="planneddate" -->')}" > > <!--TMPL_ELSE --> > <select name="status" size="1" id="status<!-- TMPL_VAR NAME="serialid" -->" onchange="if (this.value==2 || this.value==7){changeDate('<!-- TMPL_VAR NAME="arriveddate" -->')} else {changeDate('<!-- TMPL_VAR NAME="planneddate" -->')}" > > <!--/TMPL_IF--> >@@ -273,7 +276,7 @@ function CloneSubfield(index){ > <!--TMPL_IF Name="serialsadditems"--> > <tr> > <td colspan="5"> >- <a id="label<!-- TMPL_VAR NAME="subscriptionid" --><!--TMPL_VAR Name="serialid"-->" style="color: grey; font-size: 80%; cursor: pointer;" onclick="unHideItems('items<!-- TMPL_VAR NAME="subscriptionid" --><!--TMPL_VAR Name="serialid"-->','label<!-- TMPL_VAR NAME="subscriptionid" --><!--TMPL_VAR Name="serialid"-->', '<!--TMPL_VAR Name="serialid"-->')"> >+ <a id="label<!-- TMPL_VAR NAME="subscriptionid" --><!--TMPL_VAR Name="serialid"-->" style="color: grey; font-size: 80%; cursor: pointer;" onclick="unHideItems('items<!-- TMPL_VAR NAME="subscriptionid" --><!--TMPL_VAR Name="serialid"-->','label<!-- TMPL_VAR NAME="subscriptionid" --><!--TMPL_VAR Name="serialid"-->', '<!--TMPL_VAR Name="serialid"-->');setStatus(<!-- TMPL_VAR NAME="serialid" -->);"> > Click to add item</a> > <fieldset class="rows" style="display:none;" id="items<!-- TMPL_VAR NAME="subscriptionid" --><!--TMPL_VAR Name="serialid"-->"> > <legend><a style="cursor: pointer;" onclick="HideItems('items<!-- TMPL_VAR NAME="subscriptionid" --><!--TMPL_VAR Name="serialid"-->','label<!-- TMPL_VAR NAME="subscriptionid" --><!--TMPL_VAR Name="serialid"-->')"> >-- >1.7.0.4 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 4932
: 2300 |
2455