Bugzilla – Attachment 2384 Details for
Bug 5032
subscription-detail contains duplicated code
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed Patch
0001-Bug-5032-Remove-duplicate-code.patch (text/plain), 1.08 KB, created by
Colin Campbell
on 2010-07-18 16:06:47 UTC
(
hide
)
Description:
Proposed Patch
Filename:
MIME Type:
Creator:
Colin Campbell
Created:
2010-07-18 16:06:47 UTC
Size:
1.08 KB
patch
obsolete
>From 158850b1dadddad50c92cde46ccb85c656a8f195 Mon Sep 17 00:00:00 2001 >From: Colin Campbell <colin.campbell@ptfs-europe.com> >Date: Sun, 18 Jul 2010 17:02:53 +0100 >Subject: [PATCH] Bug 5032 Remove duplicate code >Content-Type: text/plain; charset="utf-8" > >Two duplicate calls to GetSerials appear to have been merged in >to no purpose other than to generate warnings >--- > serials/subscription-detail.pl | 3 --- > 1 files changed, 0 insertions(+), 3 deletions(-) > >diff --git a/serials/subscription-detail.pl b/serials/subscription-detail.pl >index b6538fe..7324d59 100755 >--- a/serials/subscription-detail.pl >+++ b/serials/subscription-detail.pl >@@ -93,9 +93,6 @@ if ($op eq 'del') { > } > } > my $hasRouting = check_routing($subscriptionid); >-my ($totalissues,@serialslist) = GetSerials($subscriptionid); >-$totalissues-- if $totalissues; # the -1 is to have 0 if this is a new subscription (only 1 issue) >-# the subscription must be deletable if there is NO issues for a reason or another (should not happend, but...) > > my ($user, $sessionID, $flags); > ($user, $cookie, $sessionID, $flags) >-- >1.7.1.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 5032
: 2384