Bugzilla – Attachment 2394 Details for
Bug 3264
Uncloning a dropdown list in MARC authorities/biblio editor may clear all subfields (see comment 17)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed patch
patch3264.txt (text/plain), 7.84 KB, created by
Fridolin Somers
on 2010-07-20 15:53:36 UTC
(
hide
)
Description:
Proposed patch
Filename:
MIME Type:
Creator:
Fridolin Somers
Created:
2010-07-20 15:53:36 UTC
Size:
7.84 KB
patch
obsolete
>=================================================================== >--- koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tmpl >+++ koha-tmpl//intranet-tmpl/prog/en/modules/authorities/authorities.tmpl >@@ -31,7 +31,7 @@ > }); > > /** >- * check if mandatory subfields are writed >+ * check if mandatory subfields are written > */ > function AreMandatoriesNotOk(){ > var mandatories = new Array(); >@@ -75,7 +75,6 @@ > for(var j=0,len2=eleminputs.length; j<len2; j++){ > > if(eleminputs[j].name.match(varegexp) && eleminputs[j].value){ >- /* tag_801_subfield_c_841304_545657 */ > inputregexp = new RegExp("^tag_" + arr[0] + "_subfield_" + eleminputs[j].value + "_" + arr[2]); > > for( var k=0; k<len2; k++){ >@@ -156,7 +155,7 @@ > newin=window.open("../authorities/auth_finder.pl?authtypecode="+ authtype+ "&index="+tagsubfieldid+"&value_mainstr="+encodeURI(mainmainstring)+"&value_main="+encodeURI(mainstring), "_blank",'width=700,height=550,toolbar=false,scrollbars=yes'); > } > >-function AddField(field,cntrepeatfield) { >+function AddField(field,cntrepeatfield) { // TODO unused > document.forms['f'].op.value = "addfield"; > document.forms['f'].addfield_field.value=field; > document.forms['f'].repeat_field.value=cntrepeatfield; >@@ -179,7 +178,7 @@ > } > > /** >- * To clone a field or a subfield by clickink on '+' button >+ * To clone a field or a subfield by clicking on '+' button > */ > function CloneField(index) { > var original = document.getElementById(index); //original <div> >@@ -261,7 +260,7 @@ > // button ... > var spans=0; > try { >- spans = divs[i].getElementsByTagName('span'); >+ spans = divs[i].getElementsByTagName('a'); > } catch(e) { > // no spans > } >@@ -317,7 +316,7 @@ > > var CloneButtonPlus; > try { >- var anchors = divs[i].getElementsByTagName('span'); >+ var anchors = divs[i].getElementsByTagName('a'); > for (var j = 0; j < anchors.length; j++) { > if (anchors[j].getAttribute('class') == 'buttonPlus') { > anchors[j].setAttribute('onclick',"CloneField('" + new_id + "')"); >@@ -537,7 +536,7 @@ > <!-- TMPL_ELSE --> > <h1>Adding authority <!-- TMPL_VAR name="authtypetext" --></h1> > <!-- /TMPL_IF --> >-<form method="post" name="f" action="/cgi-bin/koha/authorities/authorities.pl"> >+<form method="post" name="f" id="f" action="/cgi-bin/koha/authorities/authorities.pl"> > <input type="hidden" name="op" value="add" /> > <input type="hidden" name="addfield_field" value="" /> > <input type="hidden" name="repeat_field" value="" /> >@@ -658,14 +657,12 @@ > <!-- /TMPL_UNLESS --> > > <!-- TMPL_UNLESS NAME="advancedMARCEditor" --> >- <a onclick="ExpandField('tag_<!-- TMPL_VAR name="tag"-->_<!-- TMPL_VAR NAME='index'--><!-- TMPL_VAR name="random" -->')"><!-- TMPL_VAR NAME="tag_lib" --></a> >+ <a href="#" tabindex="1" class="expandfield" onclick="ExpandField('tag_<!-- TMPL_VAR name="tag"-->_<!-- TMPL_VAR NAME='index'--><!-- TMPL_VAR name="random" -->'); return false;" title="Click to Expand this Tag"><!-- TMPL_VAR NAME="tag_lib" --></a> > <!-- /TMPL_UNLESS --> > <!-- TMPL_IF name="repeatable" --> >- <span class="buttonPlus" onclick="CloneField('tag_<!-- TMPL_VAR name="tag"-->_<!-- TMPL_VAR NAME='index'--><!-- TMPL_VAR name="random" -->')">+</span> >+ <a href="#" tabindex="1" class="buttonPlus" onclick="CloneField('tag_<!-- TMPL_VAR name="tag"-->_<!-- TMPL_VAR NAME='index'--><!-- TMPL_VAR name="random" -->'); return false;" title="Repeat this Tag">+</a> >+ <a href="#" tabindex="1" class="buttonMinus" onclick="UnCloneField('tag_<!-- TMPL_VAR name="tag"-->_<!-- TMPL_VAR NAME='index'--><!-- TMPL_VAR name="random" -->'); return false;" title="Delete this Tag">−</a> > <!-- /TMPL_IF --> >- <!-- TMPL_UNLESS NAME="mandatory" --> >- <span class="buttonMinus" onclick="UnCloneField('tag_<!-- TMPL_VAR name="tag"-->_<!-- TMPL_VAR NAME='index'--><!-- TMPL_VAR name="random" -->')">−</span> >- <!-- /TMPL_UNLESS --> > > </div> > >@@ -679,7 +676,7 @@ > <!-- /TMPL_UNLESS --> > > <!-- TMPL_UNLESS name="hide_marc" --> >- <!-- TMPL_IF NAME="fixedfield" --> >+ <span class="subfieldcode"><!-- TMPL_IF NAME="fixedfield" --> > <img class="buttonUp" style="display:none;" src="<!-- TMPL_VAR NAME="themelang" -->/../img/up.png" onclick="upSubfield('subfield<!-- TMPL_VAR NAME='tag' --><!-- TMPL_VAR NAME='subfield' -->')" alt="Move Up" title="Move Up" /> > <!-- TMPL_ELSE --> > <img class="buttonUp" src="<!-- TMPL_VAR NAME="themelang" -->/../img/up.png" onclick="upSubfield('subfield<!-- TMPL_VAR NAME='tag' --><!-- TMPL_VAR NAME='subfield' -->')" alt="Move Up" title="Move Up" /> >@@ -692,27 +689,28 @@ > maxlength="1" > class="flat" > tabindex="0" /> >+ </span> > <!-- TMPL_ELSE --> > <input type="hidden" > name="tag_<!-- TMPL_VAR NAME='tag'-->_code_<!-- TMPL_VAR NAME='subfield'-->_<!-- TMPL_VAR NAME='index'-->_<!-- TMPL_VAR NAME='index_subfield'-->" > value="<!-- TMPL_VAR NAME="subfield" -->"/> >+ </span> > <!-- /TMPL_UNLESS --> > > <!-- TMPL_UNLESS NAME="advancedMARCEditor" --> >- <!-- TMPL_IF name="mandatory" --><span class="subfield_mandatory"><!-- /TMPL_IF --> >- <!-- TMPL_VAR NAME="marc_lib" --> >- <!-- TMPL_IF name="mandatory" --></span><!-- /TMPL_IF --> >+ <!-- TMPL_IF name="mandatory" --><span class="subfield subfield_mandatory"><!-- TMPL_ELSE --><span class="subfield"><!-- /TMPL_IF --> >+ <!-- TMPL_VAR NAME="marc_lib_plain" --> >+ <!-- TMPL_IF NAME="mandatory" --><span class="mandatory_marker" title="This field is mandatory">*</span><!-- /TMPL_IF --> >+ </span> > </label> > <!-- /TMPL_UNLESS --> > > <!-- TMPL_VAR NAME="marc_value" --> > > <!-- TMPL_IF NAME="repeatable" --> >- <span class="buttonPlus" onclick="CloneSubfield('subfield<!-- TMPL_VAR NAME='tag' --><!-- TMPL_VAR NAME='subfield' -->')">+</span> >- <!-- /TMPL_IF --> >- <!-- TMPL_UNLESS NAME="mandatory" --> >+ <span class="buttonPlus" onclick="CloneSubfield('subfield<!-- TMPL_VAR NAME='tag' --><!-- TMPL_VAR NAME='subfield' --><!-- TMPL_VAR name="random" -->')">+</span> > <span class="buttonMinus" onclick="UnCloneField('subfield<!-- TMPL_VAR NAME='tag' --><!-- TMPL_VAR NAME='subfield' --><!-- TMPL_VAR name="random" -->')">−</span> >- <!-- /TMPL_UNLESS --> >+ <!-- /TMPL_IF --> > > </div> > <!-- End of the line --> >@@ -749,7 +747,7 @@ > <input type="hidden" name="subfield" value="<!-- TMPL_VAR NAME="oldauthtypetagsubfield" -->" /> > <input type="hidden" name="field_value" value="<!-- TMPL_VAR NAME="authtypecode" -->" /> > <!-- /TMPL_IF --> >-<fieldset class="action"> >+<fieldset class="action" id="action" > > <input type="button" id="addauth2" value="Save" onclick="Check(this.form)" accesskey="w" /> > </fieldset> > </form>
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 3264
:
2394
|
7245
|
7661