Bugzilla – Attachment 2448 Details for
Bug 5084
GetBudgetHierarchy doesn't respect the 'active' switch on budgets
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
proposed patch
0001-Bug-5084-hide-funds-that-are-part-of-an-inactive-bud.patch (text/plain), 1.20 KB, created by
Robin Sheat
on 2010-08-04 03:43:41 UTC
(
hide
)
Description:
proposed patch
Filename:
MIME Type:
Creator:
Robin Sheat
Created:
2010-08-04 03:43:41 UTC
Size:
1.20 KB
patch
obsolete
>From ec6c4a2dbb75931f26e9792f6b8acd045061e43f Mon Sep 17 00:00:00 2001 >From: Robin Sheat <robin@catalyst.net.nz> >Date: Wed, 4 Aug 2010 14:41:30 +1200 >Subject: [PATCH] Bug 5084 - hide funds that are part of an inactive budget > >Prevents inactive funds from showing in the aquisitions module, they >still show in the administration. >--- > C4/Budgets.pm | 8 ++++++-- > 1 files changed, 6 insertions(+), 2 deletions(-) > >diff --git a/C4/Budgets.pm b/C4/Budgets.pm >index 005bba8..0882756 100644 >--- a/C4/Budgets.pm >+++ b/C4/Budgets.pm >@@ -492,9 +492,13 @@ sub GetBudgetHierarchy { > my $dbh = C4::Context->dbh; > my $query = qq| > SELECT aqbudgets.* >- FROM aqbudgets |; >- # show only period X if requested >+ FROM aqbudgets >+ LEFT JOIN aqbudgetperiods >+ ON aqbudgetperiods.budget_period_id=aqbudgets.budget_period_id |; > my @where_strings; >+ # Pick out the active ones >+ push @where_strings, 'aqbudgetperiods.budget_period_active=1'; >+ # show only period X if requested > if ($budget_period_id) { > push @where_strings," aqbudgets.budget_period_id = ?"; > push @bind_params, $budget_period_id; >-- >1.7.0.4 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 5084
: 2448