From 935923fcb9a150c63cff27425e742f4145c82ef6 Mon Sep 17 00:00:00 2001 From: Julian Maurice Date: Fri, 17 Jan 2014 11:21:05 +0100 Subject: [PATCH] [PASSED QA] Bug 11549: [follow-up] Make NewOrder calculate new parent_ordernumber If parent_ordernumber is not set in NewOrder parameter, it is automatically set to ordernumber. This patch only avoid code duplication. Signed-off-by: Jonathan Druart This solution is better! Signed-off-by: Katrin Fischer Passes all tests and QA script. Also all tests in t/db_dependent/Acquisitions/. Confirmed bug and that the patch fixes it. --- C4/Acquisition.pm | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm index 67ea46e..56c2d7f 100644 --- a/C4/Acquisition.pm +++ b/C4/Acquisition.pm @@ -1814,16 +1814,11 @@ sub TransferOrder { $rv = $sth->execute($ordernumber); delete $order->{'ordernumber'}; + delete $order->{parent_ordernumber}; $order->{'basketno'} = $basketno; my $newordernumber; (undef, $newordernumber) = NewOrder($order); - $dbh->do( q{ - UPDATE aqorders - SET parent_ordernumber = ordernumber - WHERE ordernumber = ? - }, {}, $newordernumber ); - $query = q{ UPDATE aqorders_items SET ordernumber = ? -- 1.8.3.2