From 837dbd91da2bacaaaf58d1f316e5e9c48578c6a6 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Wed, 29 Jan 2014 12:17:09 -0500 Subject: [PATCH] [PASSED QA] Bug 11636 - Impossible to remove patrons from patron list during add process If you patrons have card numbers with leading zeroes this causes problems removing patron entries during the process of adding patrons to an existing list. This patch refactors the relevant JavaScript to correct the problem and to remove inline "onclick" from generated HTML. This patch also includes a fix for Bug 11632 - Untranslatable string "Remove" in patron lists. To test: 1. If necessary, create or modify a patron to have a card number with leading zeroes. 2. Go to Tools -> Patron lists. 3. Click "Add patrons" on an existing list. 4. Perform a patron search and choose one of the results. 5. Click the "remove" link next to the patron name which was just added. Nothing will happen. 6. Apply the patch and test again. The "remove" link should now work. To test the fix for Bug 11632, after applying the patch run "translate update [language code]" and confirm that the "Remove" string is listed in the updated po file for patron_lists/list.tt. Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Passes all tests and QA script, works as described. --- koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/list.tt | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/list.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/list.tt index b0717dd..fa30be5 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/list.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/list.tt @@ -27,10 +27,17 @@ $(document).ready(function() { .append( "" + item.surname + ", " + item.firstname + " (" + item.cardnumber + ") " + item.address + " " + item.city + " " + item.zipcode + " " + item.country + "" ) .appendTo( ul ); }; + + $("body").on("click",".removePatron",function(e){ + e.preventDefault(); + var divid = $(this).parent().attr("id"); + var cardnumber = divid.replace("borrower_",""); + RemovePatron(cardnumber); + }); }); function AddPatron( name, cardnumber ) { - div = "
" + name + " ( Remove )
"; + div = "
" + name + " ( " + _("Remove") + " )
"; $('#patrons_to_add').append( div ); $('#find_patron').val('').focus(); -- 1.8.3.2