From 33d04a3dd6a313251650c95f677d2ef905f83b69 Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Mon, 10 Feb 2014 13:28:16 +0100 Subject: [PATCH] Bug 11732: Eliminate warning on undefined branchcode Content-Type: text/plain; charset=utf-8 When you run the Reserves test, you have the warnings: Use of uninitialized value $branchcode in hash element at /usr/share/koha/testclone/C4/Letters.pm line 138. Use of uninitialized value $branchcode in hash element at /usr/share/koha/testclone/C4/Letters.pm line 148. This patch removes that warning. Test plan: Run the Reserves.t again. --- C4/Letters.pm | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/C4/Letters.pm b/C4/Letters.pm index 2595369..6709294 100644 --- a/C4/Letters.pm +++ b/C4/Letters.pm @@ -126,7 +126,6 @@ our %letter; sub getletter { my ( $module, $code, $branchcode ) = @_; - $branchcode ||= ''; if ( C4::Context->preference('IndependentBranches') and $branchcode @@ -134,6 +133,7 @@ sub getletter { $branchcode = C4::Context->userenv->{'branch'}; } + $branchcode //= ''; if ( my $l = $letter{$module}{$code}{$branchcode} ) { return { %$l }; # deep copy -- 1.7.7.6