From 0ae207659d64a368b2349be0c9a0b7e334900541 Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Sun, 9 Mar 2014 18:39:11 -0300 Subject: [PATCH] [SIGNED-OFF] Bug 11912: GetMarcISBN wrongly prepends a space to ISBNs This patch makes the logic inside GetMarcISBN simpler and fixes the issue. To test: - Run the regression tests: prove -v t/db_dependent/Biblio.t => FAIL - Apply the patch - Run: prove -v t/db_dependent/Biblio.t => SUCCESS - Verify that opac-detail.pl and catalogue/detail.pl look as usual regarding ISBN - Sign off Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Nicolas Legrand --- C4/Biblio.pm | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/C4/Biblio.pm b/C4/Biblio.pm index 330951d..a34e5b6 100644 --- a/C4/Biblio.pm +++ b/C4/Biblio.pm @@ -1690,25 +1690,15 @@ sub GetMarcISBN { $scope = '020'; } my @marcisbns; - my $isbn = ""; - my $tag = ""; my $marcisbn; foreach my $field ( $record->field($scope) ) { - my $value = $field->as_string(); + my $isbn = $field->as_string(); if ( $isbn ne "" ) { $marcisbn = { marcisbn => $isbn, }; push @marcisbns, $marcisbn; - $isbn = $value; - } - if ( $isbn ne $value ) { - $isbn = $isbn . " " . $value; } } - if ($isbn) { - $marcisbn = { marcisbn => $isbn }; - push @marcisbns, $marcisbn; #load last tag into array - } return \@marcisbns; } # end GetMarcISBN -- 1.8.3.2