Bugzilla – Attachment 26392 Details for
Bug 11689
New missing statuses is not well managed
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 11689: Remove warning launching unit tests
PASSED-QA-Bug-11689-Remove-warning-launching-unit-.patch (text/plain), 2.21 KB, created by
Katrin Fischer
on 2014-03-16 21:22:16 UTC
(
hide
)
Description:
[PASSED QA] Bug 11689: Remove warning launching unit tests
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2014-03-16 21:22:16 UTC
Size:
2.21 KB
patch
obsolete
>From 9b485f6b764c47b6c16a832e95e5b23563bb4360 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Thu, 27 Feb 2014 13:12:40 +0100 >Subject: [PATCH] [PASSED QA] Bug 11689: Remove warning launching unit tests > >Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >--- > C4/Serials.pm | 8 +++++--- > t/db_dependent/Serials.t | 10 ++++++++-- > 2 files changed, 13 insertions(+), 5 deletions(-) > >diff --git a/C4/Serials.pm b/C4/Serials.pm >index e9892d2..cab381a 100644 >--- a/C4/Serials.pm >+++ b/C4/Serials.pm >@@ -2549,10 +2549,12 @@ sub GetNextDate { > # irreg1;irreg2;irreg3 > # where irregX is the number of issue which will not be received > # (the first issue takes the number 1, the 2nd the number 2 and so on) >- my @irreg = split /;/, $subscription->{'irregularity'} ; > my %irregularities; >- foreach my $irregularity (@irreg) { >- $irregularities{$irregularity} = 1; >+ if ( $subscription->{irregularity} ) { >+ my @irreg = split /;/, $subscription->{'irregularity'} ; >+ foreach my $irregularity (@irreg) { >+ $irregularities{$irregularity} = 1; >+ } > } > > # Get the 'fictive' next issue number >diff --git a/t/db_dependent/Serials.t b/t/db_dependent/Serials.t >index a363999c..f1f5d9d 100644 >--- a/t/db_dependent/Serials.t >+++ b/t/db_dependent/Serials.t >@@ -41,7 +41,7 @@ my ($biblionumber, $biblioitemnumber) = AddBiblio(MARC::Record->new, ''); > my $budgetid; > my $bpid = AddBudgetPeriod({ > budget_period_startdate => '01-01-2015', >- budget_period_enddate => '12-31-2015', >+ budget_period_enddate => '31-12-2015', > budget_description => "budget desc" > }); > >@@ -58,7 +58,13 @@ my $budget_id = AddBudget({ > my $frequency_id = AddSubscriptionFrequency({ description => "Test frequency 1" }); > my $pattern_id = AddSubscriptionNumberpattern({ > label => 'Test numberpattern 1', >- numberingmethod => '{X}' >+ numberingmethod => '{X}', >+ label1 => q{}, >+ add1 => 1, >+ every1 => 1, >+ every1 => 1, >+ numbering1 => 1, >+ whenmorethan1 => 1, > }); > > my $subscriptionid = NewSubscription( >-- >1.8.3.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11689
:
25047
|
25308
|
25537
|
25538
|
25631
|
25695
|
25696
|
26389
|
26390
|
26391
| 26392