Bugzilla – Attachment 26441 Details for
Bug 11697
Thesaurus plugin sets indicators with a space
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Indeed, there whas an error in my patch, please retest.
Bug-11697---Thesaurus-plugin-sets-indicators-with-.patch (text/plain), 1.77 KB, created by
Fridolin Somers
on 2014-03-19 07:51:13 UTC
(
hide
)
Description:
Indeed, there whas an error in my patch, please retest.
Filename:
MIME Type:
Creator:
Fridolin Somers
Created:
2014-03-19 07:51:13 UTC
Size:
1.77 KB
patch
obsolete
>From 210167048bff5e5b5316127b329b75832b7beabf Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Thu, 6 Feb 2014 14:00:54 +0100 >Subject: [PATCH] Bug 11697 - Thesaurus plugin sets indicators with a space > >When using thesaurus plugin to link a biblio field with an authority, the indicators of the field of authority are set into indicators of biblio field. >The bug is that when an indicator is not defined, it contains a space ' '. This space is then set into biblio field. The user must then erase this space before setting the indicator. > >This patch sets indicator as empty string when containing a space. > >Test plan : >- Create a new biblio record >- Select a field managed with a thesaurus. For example 700 >- Click on thesaurus plugin icon >- Search and choose an authority record with no indicator set on heading field >=> Without patch, the indicators of the biblio field (ie 700) are filled with a space character >=> With patch, the indicators of the biblio field (ie 700) are empty >- Click on plugin icon >- Search and choose an authority record with indicators set on heading field >=> The indicators are set in biblio field >--- > authorities/blinddetail-biblio-search.pl | 4 ++++ > 1 file changed, 4 insertions(+) > >diff --git a/authorities/blinddetail-biblio-search.pl b/authorities/blinddetail-biblio-search.pl >index 7bfe09e..247c005 100755 >--- a/authorities/blinddetail-biblio-search.pl >+++ b/authorities/blinddetail-biblio-search.pl >@@ -150,6 +150,10 @@ else { > my $tag_number = $index; > $tag_number =~ s/^tag_(\d*)_.*$/$1/; > >+# Indicator contains a space when not defined >+$indicator1 = q{} if $indicator1 eq q{ }; >+$indicator2 = q{} if $indicator2 eq q{ }; >+ > $template->param( > authid => $authid ? $authid : "", > index => $index, >-- >1.8.3.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11697
:
25071
| 26441