Bugzilla – Attachment 26479 Details for
Bug 11960
GetMemberDetails is unnecessarily called in CanBookBeRenewed
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED OFF] Bug 11960: GetMemberDetails is unnecessarily called in CanBookBeRenewed
SIGNED-OFF-Bug-11960-GetMemberDetails-is-unnecessa.patch (text/plain), 2.21 KB, created by
Mark Tompsett
on 2014-03-20 12:17:29 UTC
(
hide
)
Description:
[SIGNED OFF] Bug 11960: GetMemberDetails is unnecessarily called in CanBookBeRenewed
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2014-03-20 12:17:29 UTC
Size:
2.21 KB
patch
obsolete
>From c14c59678ad1b507d20ebeb61c7c9bf8ef97885f Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Wed, 19 Mar 2014 16:38:20 +0100 >Subject: [PATCH] [SIGNED OFF] Bug 11960: GetMemberDetails is unnecessarily > called in CanBookBeRenewed > >C4::Circulation::CanBookBeRenewed calls C4::Members::GetMemberDetails to >retrieve categorycode and branchcode. > >- categorycode is used to retrieve the issuing rule >- the borrower information is passed to > C4::Circulation::_GetCircControlBranch. Which only uses the branchcode > parameter. > >GetMemberDetails does a lot of useless calls/queries (patronflags, >account, etc.). > >This call could be replaced with a call to C4::Members::GetMember. > >Note: I presented this small optimisation during a quick introduction to >NYTProf (hackfest 14 in Marseille). > >Test plan: >- launch member unit tests >- check the code > >Checking the code resulted in the following: >CanBookBeRenewed builds a hash reference from the borrowernumber >(2482). Note it is only used in this function and not passed in. > >_GetCircControlBranch (2485) requires that hashreference to >have a branchcode key. As stated above. > >The following line (2486) requires it have a categorycode key. > >As such, C4::Members::GetMemberDetails is confirmed to be >overkill, and C4::Members::GetMember is sufficient. > >Testing Done >------------ >0) Back up DB >1) Make sure MPL is in the list of libraries. >2) Apply the patch. >3) run the koha qa test tool >4) prove -v t/db_dependent/Circulation.t > >Patch applies cleanly. QA Test tool was all OK. All tests ran successfully. > >Signed-off-by: Mark Tompsett <mtompset@hotmail.com> >--- > C4/Circulation.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index f8b204a..ae981a1 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -2479,7 +2479,7 @@ sub CanBookBeRenewed { > my $itemissue = GetItemIssue($itemnumber) or return ( 0, 'no_checkout' ); > > $borrowernumber ||= $itemissue->{borrowernumber}; >- my $borrower = C4::Members::GetMemberDetails($borrowernumber) >+ my $borrower = C4::Members::GetMember( borrowernumber => $borrowernumber ) > or return; > > my $branchcode = _GetCircControlBranch($item, $borrower); >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11960
:
26456
|
26459
|
26479
|
27026