From 0baaa469f29a5e9203026dcf20661046f3cc0a06 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Wed, 19 Mar 2014 16:38:20 +0100 Subject: [PATCH] Bug 11960: GetMemberDetails is unnecessarily called in CanBookBeRenewed C4::Circulation::CanBookBeRenewed calls C4::Members::GetMemberDetails to retrieve categorycode and branchcode. - categorycode is used to retrieve the issuing rule - the borrower information is passed to C4::Circulation::_GetCircControlBranch. Which only uses the branchcode parameter. GetMemberDetails does a lot of useless calls/queries (patronflags, account, etc.). This call could be replaced with a call to C4::Members::GetMember. Note: I presented this small optimisation during a quick introduction to NYTProf (hackfest 14 in Marseille). Test plan: - launch member unit tests - check the code Checking the code resulted in the following: CanBookBeRenewed builds a hash reference from the borrowernumber (2482). Note it is only used in this function and not passed in. _GetCircControlBranch (2485) requires that hashreference to have a branchcode key. As stated above. The following line (2486) requires it have a categorycode key. As such, C4::Members::GetMemberDetails is confirmed to be overkill, and C4::Members::GetMember is sufficient. Testing Done ------------ 0) Back up DB 1) Make sure MPL is in the list of libraries. 2) Apply the patch. 3) run the koha qa test tool 4) prove -v t/db_dependent/Circulation.t Patch applies cleanly. QA Test tool was all OK. All tests ran successfully. Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall --- C4/Circulation.pm | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/C4/Circulation.pm b/C4/Circulation.pm index af55225..91056e5 100644 --- a/C4/Circulation.pm +++ b/C4/Circulation.pm @@ -2480,7 +2480,7 @@ sub CanBookBeRenewed { my $itemissue = GetItemIssue($itemnumber) or return ( 0, 'no_checkout' ); $borrowernumber ||= $itemissue->{borrowernumber}; - my $borrower = C4::Members::GetMemberDetails($borrowernumber) + my $borrower = C4::Members::GetMember( borrowernumber => $borrowernumber ) or return; my $branchcode = _GetCircControlBranch($item, $borrower); -- 1.7.2.5