Bugzilla – Attachment 27323 Details for
Bug 8258
Branch specific DUEDGST notice is not used
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 8258: Use patron branchcode notice for DUEDGST and PREDUEDGST
PASSED-QA-Bug-8258-Use-patron-branchcode-notice-fo.patch (text/plain), 4.29 KB, created by
Katrin Fischer
on 2014-04-20 15:03:13 UTC
(
hide
)
Description:
[PASSED QA] Bug 8258: Use patron branchcode notice for DUEDGST and PREDUEDGST
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2014-04-20 15:03:13 UTC
Size:
4.29 KB
patch
obsolete
>From 8a45704596fb6b67532bd7006ed2c3224929605e Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Wed, 5 Mar 2014 15:08:13 +0100 >Subject: [PATCH] [PASSED QA] Bug 8258: Use patron branchcode notice for > DUEDGST and PREDUEDGST > >If a notice is defined for the branchcode of the patron, it should be >used. >Without this patch, the notice used is the one defined for all >libraries. > >Test plan: >1/ Set the advanced notice for a patron using digest. >2/ Check one item out to this patron (backdate the return date according >the days in advance value). >3/ launch advance_notices.pl -c >4/ Verify the notice used is the default one. >5/ Define a notice for the library of the patron for PREDUEDGST >6/ launch advance_notices.pl -c >7/ Verify the notice used is the one previously defined. >8/ Check one item out to this patron (date due = today) >9/ launch advance_notices.pl -c >10/ Verify the notice used is the default one. >11/ Define a notice for the library of the patron for DUEDGST >12/ launch advance_notices.pl -c >13/ Verify the notice used is the one previously defined. > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Passes all tests and QA script. >Test case: User from Library A, checked out books >- in library A from A and B >- in library B from B >Verified, that the 'all libraries' notice is still used, >when no specific notice is defined. >Verified, that the patron's home library noticed is used, >when defined. > >Note: Before and after the patch we print the branch information >from the patron's home library, so also using the template from >this branch, seems logical. All items over all branches are >processed into one single reminder email, before and after the patch. >--- > misc/cronjobs/advance_notices.pl | 38 ++++++++++++++++++++++++-------------- > 1 file changed, 24 insertions(+), 14 deletions(-) > >diff --git a/misc/cronjobs/advance_notices.pl b/misc/cronjobs/advance_notices.pl >index 178f09a..4e7149d 100755 >--- a/misc/cronjobs/advance_notices.pl >+++ b/misc/cronjobs/advance_notices.pl >@@ -349,13 +349,18 @@ PATRON: while ( my ( $borrowernumber, $digest ) = each %$upcoming_digest ) { > ## Get branch info for borrowers home library. > my %branch_info = get_branch_info( $borrowernumber ); > >- my $letter = parse_letter( { letter_code => $letter_type, >- borrowernumber => $borrowernumber, >- substitute => { count => $count, >- 'items.content' => $titles, >- %branch_info, >- } >- } ) >+ my $letter = parse_letter( >+ { >+ letter_code => $letter_type, >+ borrowernumber => $borrowernumber, >+ substitute => { >+ count => $count, >+ 'items.content' => $titles, >+ %branch_info, >+ }, >+ branchcode => $branch_info{ "branches.branchcode" }, >+ } >+ ) > or die "no letter of type '$letter_type' found. Please see sample_notices.sql"; > if ($nomail) { > local $, = "\f"; >@@ -392,13 +397,18 @@ PATRON: while ( my ( $borrowernumber, $digest ) = each %$due_digest ) { > ## Get branch info for borrowers home library. > my %branch_info = get_branch_info( $borrowernumber ); > >- my $letter = parse_letter( { letter_code => $letter_type, >- borrowernumber => $borrowernumber, >- substitute => { count => $count, >- 'items.content' => $titles, >- %branch_info, >- } >- } ) >+ my $letter = parse_letter( >+ { >+ letter_code => $letter_type, >+ borrowernumber => $borrowernumber, >+ substitute => { >+ count => $count, >+ 'items.content' => $titles, >+ %branch_info, >+ }, >+ branchcode => $branch_info{ "branches.branchcode" }, >+ } >+ ) > or die "no letter of type '$letter_type' found. Please see sample_notices.sql"; > > if ($nomail) { >-- >1.8.3.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8258
:
25846
|
25952
|
27321
| 27323