Bugzilla – Attachment 28489 Details for
Bug 12315
MTT FIX: Advanced notices are duplicated and not sent to the right patron
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 12315: Advanced notices are duplicated and not sent to the right patron
SIGNED-OFF-Bug-12315-Advanced-notices-are-duplicat.patch (text/plain), 1.58 KB, created by
Bernardo Gonzalez Kriegel
on 2014-05-27 13:08:37 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 12315: Advanced notices are duplicated and not sent to the right patron
Filename:
MIME Type:
Creator:
Bernardo Gonzalez Kriegel
Created:
2014-05-27 13:08:37 UTC
Size:
1.58 KB
patch
obsolete
>From 5c074d96783bea64155135319ce6d647100fbaf6 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Tue, 27 May 2014 10:12:20 +0200 >Subject: [PATCH] [SIGNED-OFF] Bug 12315: Advanced notices are duplicated and > not sent to the right patron > >Bug 10833 introduced a variable loop but does not reset it every iteration. > >So the first patron receives correct letters, but the followings received >all the previous ones AND his letters. > >Test plan: >0/ Delete the content of the message_queue table. >1/ Define advanced notices sent 2 days in advance for 2 patrons. >2/ Check 1 item out for each one and specify a due date today + 2 days. >3/ Launch the advance_notices.pl script. >4/ Before this patch, you got 3 notices. Now, you get 2 notices, 1 for each patron. > >Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> >Work well, no errors. > >Tested following test plan, printing on screen or saving into db, >3 messages before, 2 after (advance_notices.pl -v -n -m 2 -c) >--- > misc/cronjobs/advance_notices.pl | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/misc/cronjobs/advance_notices.pl b/misc/cronjobs/advance_notices.pl >index c7c2e0f..1fe3a66 100755 >--- a/misc/cronjobs/advance_notices.pl >+++ b/misc/cronjobs/advance_notices.pl >@@ -226,6 +226,7 @@ my $admin_adress = C4::Context->preference('KohaAdminEmailAddress'); > > my @letters; > UPCOMINGITEM: foreach my $upcoming ( @$upcoming_dues ) { >+ @letters = (); > warn 'examining ' . $upcoming->{'itemnumber'} . ' upcoming due items' if $verbose; > # warn( Data::Dumper->Dump( [ $upcoming ], [ 'overdue' ] ) ); > >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12315
:
28481
|
28489
|
28497