View | Details | Raw Unified | Return to bug 10855
Collapse All | Expand All

(-)a/C4/Serials.pm (+10 lines)
Lines 31-36 use C4::Log; # logaction Link Here
31
use C4::Debug;
31
use C4::Debug;
32
use C4::Serials::Frequency;
32
use C4::Serials::Frequency;
33
use C4::Serials::Numberpattern;
33
use C4::Serials::Numberpattern;
34
use Koha::AdditionalField;
34
35
35
use vars qw($VERSION @ISA @EXPORT @EXPORT_OK %EXPORT_TAGS);
36
use vars qw($VERSION @ISA @EXPORT @EXPORT_OK %EXPORT_TAGS);
36
37
Lines 347-353 sub GetSubscription { Link Here
347
    my $sth = $dbh->prepare($query);
348
    my $sth = $dbh->prepare($query);
348
    $sth->execute($subscriptionid);
349
    $sth->execute($subscriptionid);
349
    my $subscription = $sth->fetchrow_hashref;
350
    my $subscription = $sth->fetchrow_hashref;
351
350
    $subscription->{cannotedit} = not can_edit_subscription( $subscription );
352
    $subscription->{cannotedit} = not can_edit_subscription( $subscription );
353
354
    # Add additional fields to the subscription into a new key "additional_fields"
355
    my $additional_field_values = Koha::AdditionalField->fetch_all_values({
356
            tablename => 'subscription',
357
            record_id => $subscriptionid,
358
    });
359
    $subscription->{additional_fields} = $additional_field_values->{$subscriptionid};
360
351
    return $subscription;
361
    return $subscription;
352
}
362
}
353
363
(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt (+34 lines)
Lines 821-826 $(document).ready(function() { Link Here
821
                                    </div>
821
                                    </div>
822
                                </ol>
822
                                </ol>
823
                            </fieldset>
823
                            </fieldset>
824
825
                            [% IF additional_fields_for_subscription %]
826
                              <div id="subscription_additional_fields">
827
                                <fieldset class="rows">
828
                                  <legend>Additional fields</legend>
829
                                  <ol>
830
                                    [% FOR field IN additional_fields_for_subscription %]
831
                                      <li>
832
                                        <label for="additional_fields_[% field.name %]"> [% field.name %]: </label>
833
                                        [% IF field.authorised_value_choices %]
834
                                          <select name="additional_fields_[% field.name %]">
835
                                            [% FOREACH av IN field.authorised_value_choices %]
836
                                              [% IF av.authorised_value == additional_fields.${field.name} %]
837
                                                <option value="[% av.authorised_value %]" selected="selected">[% av.lib %]</option>
838
                                              [% ELSE %]
839
                                                <option value="[% av.authorised_value %]">[% av.lib %]</option>
840
                                              [% END %]
841
                                            [% END %]
842
                                          </select> (Authorised values for [% field.authorised_value_category %])
843
                                        [% ELSE %]
844
                                          [% IF field.marcfield %]
845
                                            <input type="text" value="[% additional_fields.${field.name} %]" name="additional_fields_[% field.name %]" readonly="readonly" />
846
                                            This value will be filled with the [% field.marcfield %] subfield of the selected biblio.
847
                                          [% ELSE %]
848
                                            <input type="text" value="[% additional_fields.${field.name} %]" name="additional_fields_[% field.name %]" />
849
                                          [% END %]
850
                                        [% END %]
851
                                      </li>
852
                                    [% END %]
853
                                  </ol>
854
                                </fieldset>
855
                              </div>
856
                            [% END %]
857
824
                            <fieldset class="action">
858
                            <fieldset class="action">
825
                                <input type="button" value="<< Previous" onclick="show_page_1();" style="float:left;"/>
859
                                <input type="button" value="<< Previous" onclick="show_page_1();" style="float:left;"/>
826
                                <input id="testpatternbutton" type="button" value="Test prediction pattern" onclick="testPredictionPattern();" />
860
                                <input id="testpatternbutton" type="button" value="Test prediction pattern" onclick="testPredictionPattern();" />
(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt (-1 / +24 lines)
Lines 1-4 Link Here
1
[% USE Branches %]
1
[% USE Branches %]
2
[% USE KohaAuthorisedValues %]
2
[% INCLUDE 'doc-head-open.inc' %]
3
[% INCLUDE 'doc-head-open.inc' %]
3
<title>Koha &rsaquo; Serials &rsaquo; Details for subscription #[% subscriptionid %]</title>
4
<title>Koha &rsaquo; Serials &rsaquo; Details for subscription #[% subscriptionid %]</title>
4
[% INCLUDE 'doc-head-close.inc' %]
5
[% INCLUDE 'doc-head-close.inc' %]
Lines 122-128 $(document).ready(function() { Link Here
122
     </ol>
123
     </ol>
123
     </div>
124
     </div>
124
     </div>
125
     </div>
125
</div>
126
     </div>
127
128
     [% IF additional_fields_for_subscription %]
129
    <div class="yui-g">
130
      <div class="yui-u first">
131
        <div class="rows">
132
          <legend>Additional fields:</legend>
133
          <ol>
134
            [% FOR field IN additional_fields_for_subscription %]
135
              <li>
136
                <span class="label">[% field.name %]:</span>
137
                [% IF field.authorised_value_category %]
138
                  [% KohaAuthorisedValues.GetByCode( field.authorised_value_category, additional_fields.${field.name} ) %]
139
                [% ELSE %]
140
                  [% additional_fields.${field.name} %]
141
                [% END %]
142
              </li>
143
            [% END %]
144
          </ol>
145
        </div>
146
      </div>
147
      </div>
148
     [% END %]
126
</div>
149
</div>
127
150
128
    <div id="subscription_planning">
151
    <div id="subscription_planning">
(-)a/serials/subscription-add.pl (+41 lines)
Lines 32-37 use C4::Serials; Link Here
32
use C4::Serials::Frequency;
32
use C4::Serials::Frequency;
33
use C4::Serials::Numberpattern;
33
use C4::Serials::Numberpattern;
34
use C4::Letters;
34
use C4::Letters;
35
use Koha::AdditionalField;
35
use Carp;
36
use Carp;
36
37
37
#use Smart::Comments;
38
#use Smart::Comments;
Lines 150-155 my $locations_loop = GetAuthorisedValues("LOC",$subs->{'location'}); Link Here
150
$template->param(branchloop => $branchloop,
151
$template->param(branchloop => $branchloop,
151
    locations_loop=>$locations_loop,
152
    locations_loop=>$locations_loop,
152
);
153
);
154
155
156
my $additional_fields = Koha::AdditionalField->all( { table => 'subscription' } );
157
for my $field ( @$additional_fields ) {
158
    if ( $field->{authorised_value_category} ) {
159
        $field->{authorised_value_choices} = GetAuthorisedValues( $field->{authorised_value_category} );
160
    }
161
}
162
$template->param( additional_fields_for_subscription => $additional_fields );
163
153
# prepare template variables common to all $op conditions:
164
# prepare template variables common to all $op conditions:
154
if ($op!~/^mod/) {
165
if ($op!~/^mod/) {
155
    letter_loop(q{}, $template);
166
    letter_loop(q{}, $template);
Lines 335-340 sub redirect_add_subscription { Link Here
335
        $skip_serialseq
346
        $skip_serialseq
336
    );
347
    );
337
348
349
    my $additional_fields = Koha::AdditionalField->all( { table => 'subscription' } );
350
    my @additional_field_values;
351
    for my $field ( @$additional_fields ) {
352
        my $af = Koha::AdditionalField->new({ id => $field->{id} });
353
        $af->{values} = {
354
            $subscriptionid => $query->param('additional_fields_' . $field->{name})
355
        };
356
        $af->insert_values;
357
    }
358
338
    print $query->redirect("/cgi-bin/koha/serials/subscription-detail.pl?subscriptionid=$subscriptionid");
359
    print $query->redirect("/cgi-bin/koha/serials/subscription-detail.pl?subscriptionid=$subscriptionid");
339
    return;
360
    return;
340
}
361
}
Lines 410-415 sub redirect_mod_subscription { Link Here
410
        $skip_serialseq
431
        $skip_serialseq
411
    );
432
    );
412
433
434
    my $additional_fields = Koha::AdditionalField->all( { table => 'subscription' } );
435
    my @additional_field_values;
436
    for my $field ( @$additional_fields ) {
437
        my $af = Koha::AdditionalField->new({ id => $field->{id} })->fetch;
438
        if ( $af->{marcfield} ) {
439
            my $record = GetMarcBiblio( $biblionumber, 1 );
440
            my ( $field, $subfield ) = split /\$/, $af->{marcfield};
441
            next unless $field and $subfield;
442
            my $value = $record->subfield( $field, $subfield );
443
            $af->{values} = {
444
                $subscriptionid => $value
445
            };
446
        } else {
447
            $af->{values} = {
448
                $subscriptionid => $query->param('additional_fields_' . $field->{name})
449
            };
450
        }
451
        $af->insert_values;
452
    }
453
413
    print $query->redirect("/cgi-bin/koha/serials/subscription-detail.pl?subscriptionid=$subscriptionid");
454
    print $query->redirect("/cgi-bin/koha/serials/subscription-detail.pl?subscriptionid=$subscriptionid");
414
    return;
455
    return;
415
}
456
}
(-)a/serials/subscription-detail.pl (-1 / +8 lines)
Lines 137-142 if ( defined $subscriptionid ) { Link Here
137
    }
137
    }
138
}
138
}
139
139
140
my $additional_fields = Koha::AdditionalField->all( { tablename => 'subscription' } );
141
for my $field ( @$additional_fields ) {
142
    if ( $field->{authorised_value_category} ) {
143
        $field->{authorised_value_choices} = GetAuthorisedValues( $field->{authorised_value_category} );
144
    }
145
}
146
$template->param( additional_fields_for_subscription => $additional_fields );
147
140
$template->param(
148
$template->param(
141
    subscriptionid => $subscriptionid,
149
    subscriptionid => $subscriptionid,
142
    serialslist => \@serialslist,
150
    serialslist => \@serialslist,
143
- 

Return to bug 10855