Bugzilla – Attachment 29228 Details for
Bug 11872
Lost overdue items should not generate fines
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11872 [QA Followup] - Unit Tests
Bug-11872-QA-Followup---Unit-Tests.patch (text/plain), 1.86 KB, created by
Kyle M Hall
on 2014-06-25 16:29:46 UTC
(
hide
)
Description:
Bug 11872 [QA Followup] - Unit Tests
Filename:
MIME Type:
Creator:
Kyle M Hall
Created:
2014-06-25 16:29:46 UTC
Size:
1.86 KB
patch
obsolete
>From b3e44063441330ae7ef9eede5d2cf1f8a80882db Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Wed, 25 Jun 2014 12:30:00 -0400 >Subject: [PATCH] Bug 11872 [QA Followup] - Unit Tests > >--- > t/db_dependent/Circulation.t | 11 +++++++++-- > 1 files changed, 9 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t >index 6b25208..21ad150 100755 >--- a/t/db_dependent/Circulation.t >+++ b/t/db_dependent/Circulation.t >@@ -9,7 +9,7 @@ use C4::Items; > use C4::Members; > use C4::Reserves; > >-use Test::More tests => 48; >+use Test::More tests => 50; > > BEGIN { > use_ok('C4::Circulation'); >@@ -244,7 +244,7 @@ C4::Context->dbh->do("DELETE FROM accountlines"); > my $datedue = AddIssue( $renewing_borrower, $barcode); > is (defined $datedue, 1, "Item 1 checked out, due date: $datedue"); > >- my $datedue2 = AddIssue( $renewing_borrower, $barcode2); >+ my $datedue2 = AddIssue( $renewing_borrower, $barcode2, DateTime->now(time_zone => C4::Context->tz())->subtract( days => 1 ) ); > is (defined $datedue2, 1, "Item 2 checked out, due date: $datedue2"); > > my $borrowing_borrowernumber = GetItemIssue($itemnumber)->{borrowernumber}; >@@ -253,6 +253,13 @@ C4::Context->dbh->do("DELETE FROM accountlines"); > my ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber, 1); > is( $renewokay, 1, 'Can renew, no holds for this title or item'); > >+ my $overdues = C4::Overdues::Getoverdues(); >+ ok( scalar @$overdues == 1, 'One overdue item found as expected' ); >+ $dbh->do("UPDATE items SET itemlost = 1 WHERE itemnumber = ?", undef, $itemnumber2); >+ $overdues = C4::Overdues::Getoverdues(); >+ ok( scalar @$overdues == 0, 'Zero overdue items found as expected, only overdue item is marked as lost' ); >+ >+ > > diag("Biblio-level hold, renewal test"); > AddReserve( >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11872
:
25720
|
25830
|
29228
|
30294
|
33913
|
33980