From a4770a67bd824102cc8b7a99b5d2536549bafa1c Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Wed, 2 Jul 2014 09:00:46 -0400 Subject: [PATCH] Bug 10912 - Streamline hold error messages in staff interface Right now, if a patron cannot place a hold on any items on a record, the error in the staff intranet looks like this: Cannot place hold Too Many Holds: Kyle Hall has too many holds. No copies are available to be placed on hold This can confuse some librarians, because the reason the patron cannot place the hold is not because the patron has too many holds, but only because there are no copies available. Test Plan: 1) Apply this patch 2) Set the number of holds allowed to 1 3) Disable AllowOnShelfHolds 4) Place a hold for a patron 5) Attempt to place a second hold for the patron 6) You should see the "Too many holds" message 7) Set the number of holds allowed to 2 8) Repeat 5, you should be allowed to place the hold, but don't 9) Attempt to place a hold on a record with only checked in items 10) You should get a "No items are available" message --- .../prog/en/modules/reserve/request.tt | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt index cafc072..071ba09 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt @@ -245,13 +245,14 @@ function checkMultiHold() {