From fe442b9e28099f56d108f986d96670424959f3c5 Mon Sep 17 00:00:00 2001 From: Colin Campbell Date: Thu, 6 Jan 2011 11:32:49 +0000 Subject: [PATCH] Bug 5583 Rename fieldnumber to blocknumber Content-Type: text/plain; charset="utf-8" Variable fieldnumber does not refer to a field It is the ISBD block number Rename to blocknumber Say what we mean adds to maintainability --- .../prog/en/modules/cataloguing/addbiblio.tmpl | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tmpl index d0db063..b33f897 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tmpl +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tmpl @@ -67,11 +67,11 @@ function PopupZ3950() { } } -function PopupMARCFieldDoc(field, fieldnumber) { +function PopupMARCFieldDoc(field, blocknumber) { _MARC21FieldDoc(field); - _UNIMARCFieldDoc(field, fieldnumber); + _UNIMARCFieldDoc(field, blocknumber); } @@ -85,7 +85,7 @@ function _MARC21FieldDoc(field) { } } -function _UNIMARCFieldDoc(field,fieldnumber) { +function _UNIMARCFieldDoc(field, blocknumber) { /* http://archive.ifla.org/VI/3/p1996-1/ is an outdated version of UNIMARC, but seems to be the only version available that can be linked to per tag. More recent versions of the UNIMARC standard are available on the IFLA website only as @@ -94,9 +94,9 @@ function _UNIMARCFieldDoc(field,fieldnumber) { if(field == 0) { window.open("http://archive.ifla.org/VI/3/p1996-1/uni.htm"); } else if (field < 100) { - window.open("http://archive.ifla.org/VI/3/p1996-1/uni"+fieldnumber+".htm#b" + ("000"+field).slice(-3)); + window.open("http://archive.ifla.org/VI/3/p1996-1/uni"+blocknumber+".htm#b" + ("000"+field).slice(-3)); } else if (field < 900) { - window.open("http://archive.ifla.org/VI/3/p1996-1/uni"+fieldnumber+".htm#" + ("000"+field).slice(-3)); + window.open("http://archive.ifla.org/VI/3/p1996-1/uni"+blocknumber+".htm#" + ("000"+field).slice(-3)); } else { window.open("http://archive.ifla.org/VI/3/p1996-1/uni9.htm"); } -- 1.7.3.4