Bugzilla – Attachment 29586 Details for
Bug 12330
hide item types, collections, locations on advanced search if hidden by opachiddenitems
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 12330: [QA Follow-up] Consistency between opac-search and staff client
Bug-12330-QA-Follow-up-Consistency-between-opac-se.patch (text/plain), 1.36 KB, created by
Marcel de Rooy
on 2014-07-09 14:12:34 UTC
(
hide
)
Description:
Bug 12330: [QA Follow-up] Consistency between opac-search and staff client
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2014-07-09 14:12:34 UTC
Size:
1.36 KB
patch
obsolete
>From 17115091fcc5802d0a6aec25fcf8e718909eb407 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Wed, 9 Jul 2014 15:56:54 +0200 >Subject: [PATCH] Bug 12330: [QA Follow-up] Consistency between opac-search > and staff client >Content-Type: text/plain; charset=utf-8 > >In opac-search two regexes are added for the results of splitting the >pref AdvancedSearchTypes, allowing spaces before and after the names. >The same regexes should be added to catalogue/search.pl to have the >same behavior there. > >Test plan: >Set AdvancedSearchTypes to "itemtypes | ccode | loc " (no quotes). >Check OPAC and staff with and without this patch. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > catalogue/search.pl | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > >diff --git a/catalogue/search.pl b/catalogue/search.pl >index 629a317..0977f73 100755 >--- a/catalogue/search.pl >+++ b/catalogue/search.pl >@@ -258,6 +258,8 @@ my $advanced_search_types = C4::Context->preference("AdvancedSearchTypes") || "i > my @advanced_search_types = split(/\|/, $advanced_search_types); > > foreach my $advanced_srch_type (@advanced_search_types) { >+ $advanced_srch_type =~ s/^\s*//; >+ $advanced_srch_type =~ s/\s*$//; > if ($advanced_srch_type eq 'itemtypes') { > # itemtype is a special case, since it's not defined in authorized values > my @itypesloop; >-- >1.7.7.6
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12330
:
28565
|
28566
|
28570
|
29585
| 29586