From 2602eea521d41db902a790b178c50001b3147058 Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Mon, 28 Jul 2014 10:18:59 -0500 Subject: [PATCH] Bug 12432 - Saved reports tabs not working In release 3.14.05.000 the tabs on the Saved Reports page worked correctly but after upgrading to 3.16.00.000 the tabs stop working. Visually the tabs change but the table of reports is not filtered. There are no errors reported in the browser console. Test Plan: 1) Attempt to filter saved reports by group tabs 2) Note no matter the tab you select, all reports appear 3) Apply this patch 4) Repeat step 1 5) Note the reports are now filtered correctly Signed-off-by: Christopher Brannon --- .../en/modules/reports/guided_reports_start.tt | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt index 225ee83..9be145d 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt @@ -76,7 +76,7 @@ $(document).ready(function(){ })); var rtabs = $("#tabs").tabs(); - rtabs.bind("tabsshow", function(e, ui) { + rtabs.on("tabsactivate", function(e, ui) { $("#subgroup_filter option").each(function() { if($(this).val().length > 0) { $(this).remove(); @@ -87,8 +87,9 @@ $(document).ready(function(){ rtable.fnSetColumnVis(4, true); rtable.fnSetColumnVis(5, true); - var g_id = $(ui.tab).attr('id') - var g_name = $(ui.tab).text(); + var g_id = $(ui.newTab).children().attr('id'); + var g_name = $(ui.newTab).text(); + if (g_id && g_id.length > 0) { rtable.fnFilter('^' + g_name + '$', 4, true, true, true, false); rtable.fnSetColumnVis(4, false); -- 1.7.2.5