Bugzilla – Attachment 30347 Details for
Bug 12672
GetMarcISBN should return the corresponding subfield
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 12672: GetMarcISBN should return the corresponding subfield
SIGNED-OFF-Bug-12672-GetMarcISBN-should-return-the.patch (text/plain), 1.16 KB, created by
Bernardo Gonzalez Kriegel
on 2014-07-30 15:06:24 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 12672: GetMarcISBN should return the corresponding subfield
Filename:
MIME Type:
Creator:
Bernardo Gonzalez Kriegel
Created:
2014-07-30 15:06:24 UTC
Size:
1.16 KB
patch
obsolete
>From e99d6d67da7ee98240e68a057bf235e354ae38ac Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@gmail.com> >Date: Tue, 29 Jul 2014 13:55:44 -0300 >Subject: [PATCH] [SIGNED-OFF] Bug 12672: GetMarcISBN should return the > corresponding subfield > >The current GetMarcISBN implementation returns an array of ISBN >in which all subfields of a ISBN field occurence are appended. > >For example, in MARC21, if you have $a and $c defined, they will >be appended for output. This happens for $z. > >To reproduce: >- Run the regression tests attached to this bug. > >To test: >- Apply the patch, regression tests pass. >- Sign off > >Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> > >Now test pass, no koha-qa errors >--- > C4/Biblio.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Biblio.pm b/C4/Biblio.pm >index f5903f3..78e2bad 100644 >--- a/C4/Biblio.pm >+++ b/C4/Biblio.pm >@@ -1711,7 +1711,7 @@ sub GetMarcISBN { > > my @marcisbns; > foreach my $field ( $record->field($scope) ) { >- my $isbn = $field->as_string(); >+ my $isbn = $field->subfield( 'a' ); > if ( $isbn ne "" ) { > push @marcisbns, $isbn; > } >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12672
:
30295
|
30296
|
30346
|
30347
|
30502
|
30503