From 7768199d3146236528423ef28e039d45895019c4 Mon Sep 17 00:00:00 2001 From: simith Date: Thu, 3 Jul 2014 08:32:32 -0400 Subject: [PATCH] [PASSED QA] Bug 12523 - Add patron email in Holds awaiting pickup circulation rapport Modified: circ/waitingreservers.pl - added GetFirstValidEmailAddress Testing: I Apply the patch 0) Put an item in hold for pickup; 1) In Circulation -> Holds awaiting pickup, validate email (column Patron); Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Works as described and will use the first valid email address. --- circ/waitingreserves.pl | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/circ/waitingreserves.pl b/circ/waitingreserves.pl index b7b890d..07190a1 100755 --- a/circ/waitingreserves.pl +++ b/circ/waitingreserves.pl @@ -128,10 +128,13 @@ foreach my $num (@getreserves) { $getreserv{'borrowername'} = $getborrower->{'surname'}; $getreserv{'borrowerfirstname'} = $getborrower->{'firstname'}; $getreserv{'borrowerphone'} = $getborrower->{'phone'}; - if ( $getborrower->{'emailaddress'} ) { - $getreserv{'borrowermail'} = $getborrower->{'emailaddress'}; + + my $borEmail = GetFirstValidEmailAddress( $borrowernum ); + + if ( $borEmail ) { + $getreserv{'borrowermail'} = $borEmail; } - + if ($today > $calcDate) { if ($cancelall) { my $res = cancel( $itemnumber, $borrowernum, $holdingbranch, $homebranch, !$transfer_when_cancel_all ); -- 1.9.1