From 63d3b806883e822cf30d1fa8189e41b77cfdea41 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Fri, 1 Aug 2014 14:58:35 -0400 Subject: [PATCH] [Signed-off] Bug 12693 - colspan calculation done by members/statistics.pl should be moved to template MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit It is not necessary for the patron statistics script to pass a colspan value to the template. The number can be output using Template::Toolkit syntax. To test, view the statistics page for a patron. Confirm that the "Total" cell in the footer spans the correct number of columns. Test with various numbers of fields in the StatisticsFields system preference. Followed test plan. Patch behaves as expected. Signed-off-by: Marc VĂ©ron --- koha-tmpl/intranet-tmpl/prog/en/modules/members/statistics.tt | 2 +- members/statistics.pl | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/statistics.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/statistics.tt index b034613..876559a 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/statistics.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/statistics.tt @@ -78,7 +78,7 @@ - TOTAL + TOTAL [% count_total_precedent_state %] [% count_total_issues %] [% count_total_issues_returned %] diff --git a/members/statistics.pl b/members/statistics.pl index 15a1c69..af31815 100755 --- a/members/statistics.pl +++ b/members/statistics.pl @@ -105,7 +105,6 @@ $template->param( datas => $datas, address => $address, column_names => \@statistic_column_names, - length_keys => scalar( @statistic_column_names), count_total_issues => $count_total_issues, count_total_issues_returned => $count_total_issues_returned, count_total_precedent_state => $count_total_precedent_state, -- 1.7.10.4