From 8ac69bec1cd9f6318203d104e5e6a757edc57834 Mon Sep 17 00:00:00 2001 From: Jacek Ablewicz Date: Sat, 2 Aug 2014 10:13:16 +0200 Subject: [PATCH] [SIGNED-OFF] Bug 12697 - Surplus closing in OPAC advanced search (bootstrap) In koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt template, there is a surplus closing in line 336 (= line 332, in case Bug 12521 is applied first): 336: which causes some minor layout problems for this page - i.e.: page footer ("Powered by Koha" + custom footer set up in system prefrences - if any) is "glued" to the bottom (to the language selection bar); unless Bug 12521 is applied first, this affects the placement of the 2nd search bar as well. To reproduce: 1/ go to the OPAC advanced search page 2/ zoom out (e.g., use Ctrl- several times) and obeserve the result 3/ no need for step 2/ (zooming out) when using a display with (relatively) high vertical resolution; also, this particullar problem gets more apparent/more noticeable with MARC21/USMASRC "subtype" options being hidden in the OPAC advanced search (Bug 9043). To test: 1/ ensure that Bug 12521 is applied first/already applied 2/ apply patch 3/ confirm that this issue is no longer reroductible Signed-off-by: Bernardo Gonzalez Kriegel On top of 12521, don't know exactly what to reproduce, but surplus '' is real (33 open, 34 close). Everything looks correct, no koha-qa errors. --- .../bootstrap/en/modules/opac-advsearch.tt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt index d194636..1879b45 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt @@ -321,7 +321,8 @@ - [% END # / IF usmarc %] + + [% END # / IF usmarc %] [% IF ( UNIMARC ) %]
@@ -329,7 +330,7 @@ [% INCLUDE 'subtypes_unimarc.inc' %]
[% END %] - + [% END # / IF expanded_options %] -- 1.7.9.5