Bugzilla – Attachment 30653 Details for
Bug 4231
Placing holds from cart fails silently
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 4231 - Placing holds from cart fails silently
Bug-4231---Placing-holds-from-cart-fails-silently.patch (text/plain), 1.58 KB, created by
Marc Véron
on 2014-08-09 19:33:19 UTC
(
hide
)
Description:
Bug 4231 - Placing holds from cart fails silently
Filename:
MIME Type:
Creator:
Marc Véron
Created:
2014-08-09 19:33:19 UTC
Size:
1.58 KB
patch
obsolete
>From 41aa12cc847db4bd6f042c245b4750919771f17e Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Marc=20V=C3=A9ron?= <veron@veron.ch> >Date: Sun, 27 Jul 2014 20:30:47 +0200 >Subject: [PATCH] Bug 4231 - Placing holds from cart fails silently > >This patch adds a more meaningfull message if multiple biblios with no items attached are in the cart. > >To test: >- Add biblios with and without items to cart >- Go to cart, select all and click 'Place hold' > >Without patch, message reads: >Cannot place hold: this record has no items attached. > >With patch, message reads: >Cannot place hold: one or more records without items attached. >--- > koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >index cafc072..60551f4 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >@@ -182,9 +182,13 @@ function checkMultiHold() { > <div id="yui-main"> > <div class="yui-b"> > [% IF ( noitems ) %] >-<div class="dialog alert"> >-<strong>Cannot place hold:</strong> this record has no items attached. >-</div> >+ <div class="dialog alert"> >+ [%IF (multi_hold) %] >+ <strong>Cannot place hold:</strong> one or more records without items attached. >+ [% ELSE %] >+ <strong>Cannot place hold:</strong> this record has no items attached. >+ [% END %] >+ </ div> > [% ELSE %] > [% IF ( messagetransfert ) %] > <div class="dialog message"> >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 4231
:
30653
|
30705
|
30856