Bugzilla – Attachment 30686 Details for
Bug 8938
Transport cost matrix script and template contain untranslatable strings
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[Signed-off] Bug 8938: Transport cost matrix script and template contain untranslatable strings
Signed-off-Bug-8938-Transport-cost-matrix-script-a.patch (text/plain), 2.77 KB, created by
Marc Véron
on 2014-08-11 09:10:13 UTC
(
hide
)
Description:
[Signed-off] Bug 8938: Transport cost matrix script and template contain untranslatable strings
Filename:
MIME Type:
Creator:
Marc Véron
Created:
2014-08-11 09:10:13 UTC
Size:
2.77 KB
patch
obsolete
>From b5f3e57f876467dcd6f70a57980199b5cdceb783 Mon Sep 17 00:00:00 2001 >From: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> >Date: Sun, 10 Aug 2014 21:10:12 -0300 >Subject: [PATCH] [Signed-off] Bug 8938: Transport cost matrix script and > template contain untranslatable strings >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >This patch fixes the problem reported. > >To test: >1) Apply the patch >2) Update translations for your preffered language, xx-YY >3) Check new entries >egrep -Rn "Cost must be expressed as a decimal number|Invalid value for" misc/translator/xx-YY* >4) Check no regression on alert, go to >Administration > Transport cost matrix >Edit some value and put a negative value & save, >alert must show up >5) On errors, part of the error string is now on TT file, >no regressions expected here > >Verified that changes appear in translated language (de-CH) as appropriate. No regressions found by testing en en de-CH. >Signed-off-by: Marc Véron <veron@veron.ch> >--- > admin/transport-cost-matrix.pl | 2 +- > .../intranet-tmpl/prog/en/modules/admin/transport-cost-matrix.tt | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/admin/transport-cost-matrix.pl b/admin/transport-cost-matrix.pl >index 91f01d6..db34c6f 100755 >--- a/admin/transport-cost-matrix.pl >+++ b/admin/transport-cost-matrix.pl >@@ -82,7 +82,7 @@ foreach my $branchfrom ( @branchloop ) { > $from_to_input_def{disabled} = 1; > } > else { >- push @errors, "Invalid value for $from_row{name} -> $from_to_input_def{name}" >+ push @errors, "$from_row{name} -> $from_to_input_def{name}" > unless $value =~ /\d/o && $value >= 0.0; > } > } >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/transport-cost-matrix.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/transport-cost-matrix.tt >index 4ec0710..fb36d0e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/transport-cost-matrix.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/transport-cost-matrix.tt >@@ -9,7 +9,7 @@ function check_transport_cost(e) { > if (val && val != '' && !isNaN(parseFloat(val)) && val >= 0.0) { > return; > } >- alert("Cost must be expressed as a decimal number >= 0"); >+ alert(_("Cost must be expressed as a decimal number >= 0")); > } > function disable_transport_cost_chg(e, cost_id) { > disable_transport_cost(cost_id, e.checked); >@@ -69,7 +69,7 @@ function form_submit (f) { > <h4>There were problems with your submission</h4> > <ul> > [% FOR e IN errors %] >- <li>[% e %]</li> >+ <li>Invalid value for [% e %]</li> > [% END %] > </ul> > </div>[% END %] >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8938
:
30676
|
30683
|
30686
|
30803