From c50813623197c6092901e536566e58fe956fe525 Mon Sep 17 00:00:00 2001 From: Bernardo Gonzalez Kriegel Date: Sun, 3 Aug 2014 16:55:44 -0300 Subject: [PATCH] [PASSED QA] Bug 12707: Remove CGI::scrolling_list from some Reports MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This patch removes similar instances on 5 files, same code. Also removes a commented one, changed in case some plan to resurrect the code. This bug depends on Bug 12696. In all cases but the commented one, what was replaced is a pulldown with one value, 'CSV' To test: 1. Apply patch for Bug 12696 2. Apply this patch Check for the pulldown 'Into an application' 3. Go to Reports > Statistics wizard > Borrowers 4. Go to Reports > Statistics wizard > Circulation 5. Go to Reports > Statistics wizard > Holds 6. Go to Reports > Top lists > Most-circulated items 7. Go to Reports > Inactive > Patrons who haven't checked out 8. There is also a commented code on catalogue_stats, no fuctional changes. Followed test plan. Patch behaves as expected. Signed-off-by: Marc VĂ©ron Signed-off-by: Katrin Fischer Works as described, passes tests and QA script. --- .../intranet-tmpl/prog/en/modules/reports/borrowers_out.tt | 6 +++++- .../intranet-tmpl/prog/en/modules/reports/borrowers_stats.tt | 6 +++++- .../intranet-tmpl/prog/en/modules/reports/cat_issues_top.tt | 6 +++++- .../intranet-tmpl/prog/en/modules/reports/issues_stats.tt | 6 +++++- .../intranet-tmpl/prog/en/modules/reports/reserves_stats.tt | 6 +++++- reports/borrowers_out.pl | 8 +------- reports/borrowers_stats.pl | 7 +------ reports/cat_issues_top.pl | 8 +------- reports/catalogue_stats.pl | 8 +++----- reports/issues_stats.pl | 8 +------- reports/reserves_stats.pl | 10 +--------- 11 files changed, 33 insertions(+), 46 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_out.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_out.tt index 8d76853..bc6e6b2 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_out.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_out.tt @@ -102,7 +102,11 @@ $(document).ready(function(){ - [% CGIextChoice %] + - [% CGIextChoice %] + - [% CGIextChoice %] + - [% CGIextChoice %] + - [% CGIextChoice %] +