Bugzilla – Attachment 30853 Details for
Bug 12706
Remove CGI::scrolling_list from serial_stats.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 12706: Remove CGI::scrolling_list from serial_stats.pl
PASSED-QA-Bug-12706-Remove-CGIscrollinglist-from-s.patch (text/plain), 2.62 KB, created by
Katrin Fischer
on 2014-08-15 17:07:33 UTC
(
hide
)
Description:
[PASSED QA] Bug 12706: Remove CGI::scrolling_list from serial_stats.pl
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2014-08-15 17:07:33 UTC
Size:
2.62 KB
patch
obsolete
>From a5b6e021e8df31ed00aae778c9ea75ab7657deb8 Mon Sep 17 00:00:00 2001 >From: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> >Date: Sun, 3 Aug 2014 16:08:38 -0300 >Subject: [PATCH] [PASSED QA] Bug 12706: Remove CGI::scrolling_list from > serial_stats.pl >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >This patch depends on Bug 12696 > >Removed one instance in this file. >Pulldown with one value, 'CSV' > >To test: >1. Apply the patch for Bug 12696 >2. Apply this patch >3. Go to Reports > Statistics wizard > Serial >4. Check 'Into an application' pulldown, with value 'CSV' >5. Search for regressions > >Followed test plan. Patch behaves as expected. >Signed-off-by: Marc Véron <veron@veron.ch> >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Passes tests and QA script, works as described. >--- > koha-tmpl/intranet-tmpl/prog/en/modules/reports/serials_stats.tt | 6 +++++- > reports/serials_stats.pl | 7 +------ > 2 files changed, 6 insertions(+), 7 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/serials_stats.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/serials_stats.tt >index 90e96ec..6e7b8ab 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/serials_stats.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/serials_stats.tt >@@ -121,7 +121,11 @@ > <label for="outputfile">To a file:</label> <input type="radio" name="output" value="file" id="outputfile" /> > <label class="inline" for="basename">Named: </label><input type="text" name="basename" id="basename" value="Export" /> > <label class="inline" for="MIME">Into an application</label> >- [% CGIextChoice %] >+ <select name="MIME" id="MIME" size="1"> >+ [% FOREACH value IN CGIextChoice %] >+ <option value="[% value %]">[% value %]</option> >+ [% END %] >+ </select> > <select name="sep" id="sep" size="1"> > [% FOREACH value IN CGIsepChoice.values.sort() %] > [% IF ( value == CGIsepChoice.default ) %] >diff --git a/reports/serials_stats.pl b/reports/serials_stats.pl >index 681ddf1..c7644c8 100755 >--- a/reports/serials_stats.pl >+++ b/reports/serials_stats.pl >@@ -150,12 +150,7 @@ if($do_it){ > push(@booksellers,$row) > } > >- my $CGIextChoice=CGI::scrolling_list( >- -name => 'MIME', >- -id => 'MIME', >- -values => ['CSV'], # FIXME translation >- -size => 1, >- -multiple => 0 ); >+ my $CGIextChoice = ( 'CSV' ); # FIXME translation > my $CGIsepChoice=GetDelimiterChoices; > $template->param( > CGIextChoice => $CGIextChoice, >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12706
:
30520
|
30543
| 30853