Bugzilla – Attachment 31036 Details for
Bug 12784
A patron cannot change his personal details
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 12784: Patron cannot change his personal details
PASSED-QA-Bug-12784-Patron-cannot-change-his-perso.patch (text/plain), 1.96 KB, created by
Katrin Fischer
on 2014-08-21 07:02:03 UTC
(
hide
)
Description:
[PASSED QA] Bug 12784: Patron cannot change his personal details
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2014-08-21 07:02:03 UTC
Size:
1.96 KB
patch
obsolete
>From 784ae286f42a4caba337caf332d5d7c5601157d3 Mon Sep 17 00:00:00 2001 >From: Yohann Dufour <dufour.yohann@gmail.com> >Date: Tue, 19 Aug 2014 11:02:47 +0200 >Subject: [PATCH] [PASSED QA] Bug 12784: Patron cannot change his personal > details >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >This patch fixes the regression introduced by the bug 12623 : a patron cannot change his personal details from OPAC. > >Test plans : >In order to test this patch, first you have to apply the patch of bug 12781 > >a1/ Login with a user in OPAC >a2/ Request some modification (surname for example) >a3/ Repeat 2/ >a4/ There are no errors > >b1/ Register a new user from OPAC with the syspref : >PatronSelfRegistrationVerifyByEmail with the value "Require" >b2/ There are no errors > >Followed test plan. Patch behaves as expected. >Signed-off-by: Marc Véron <veron@veron.ch> > >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Patch works as expected, passes tests and QA script. > >Note: The second patron modification request >of one patron will overwrite his/her first request. >--- > Koha/Borrower/Modifications.pm | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >diff --git a/Koha/Borrower/Modifications.pm b/Koha/Borrower/Modifications.pm >index 00083fb..d015655 100644 >--- a/Koha/Borrower/Modifications.pm >+++ b/Koha/Borrower/Modifications.pm >@@ -51,16 +51,18 @@ sub AddModifications { > if( $self->{borrowernumber} ) { > return if( not keys %$data ); > $data->{borrowernumber} = $self->{borrowernumber}; >+ $data->{verification_token} = ''; > } > elsif( $self->{verification_token} ) { > $data->{verification_token} = $self->{verification_token}; >+ $data->{borrowernumber} = 0; > } > else { > return; > } > > my $rs = Koha::Database->new()->schema->resultset('BorrowerModification'); >- return $rs->update_or_create($data); >+ return $rs->update_or_create($data, { key => 'primary' } ); > } > > =head2 Verify >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12784
:
30972
|
30992
| 31036