From 3d484e516f5f1e0ea3530aab7d82a9b163c335a1 Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Tue, 26 Aug 2014 18:09:42 -0300 Subject: [PATCH] Bug 12829: (MARC21) properly skip 020z when rendering ISBN for normal record display Currently, 020$z oocurences are not shown, but the XSLT logic used is introducing punctuation characters for those $z occurences. This patch adds a check for the existence of subfield a, and skips otherwise. To test: - Create/have a record with 020$z (one or more) but no 020$a. - Open the detail page for the record (on both OPAC and staff). => FAIL: the ISBN label and ';' and '.' characters incorrectly shown. - Repeat mixing with 020$a occurences to notice the bug. - Apply the patch, reload => SUCCES: ISBN label shows only on the presence of a 020$a, and 020$z are skipped. - Sign off :-D Regards To+ --- .../prog/en/xslt/MARC21slim2intranetDetail.xsl | 16 +++++++++++----- .../bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 18 +++++++++++------- 2 files changed, 22 insertions(+), 12 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl index 003f528..daab51b 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl +++ b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl @@ -378,15 +378,21 @@ - + ISBN: - - - .; + + + + + . + ; + + + - + ISSN: diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl index 6e22599..c4532ea 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl +++ b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl @@ -415,17 +415,21 @@ - + ISBN: - - - - .; - + + + + + . + ; + + + - + ISSN: -- 1.9.1