Bugzilla – Attachment 31190 Details for
Bug 11672
Untranslatable report areas in step 1 of Guided Reports
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 11672: (followup) warnings tested
SIGNED-OFF-Bug-11672-followup-warnings-tested.patch (text/plain), 1.42 KB, created by
Owen Leonard
on 2014-08-27 13:21:33 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 11672: (followup) warnings tested
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2014-08-27 13:21:33 UTC
Size:
1.42 KB
patch
obsolete
>From d66c5ebdfeb8c0a041550d526562c785333aeb4b Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@gmail.com> >Date: Wed, 27 Aug 2014 10:11:28 -0300 >Subject: [PATCH] [SIGNED-OFF] Bug 11672: (followup) warnings tested >Content-Type: text/plain; charset="utf-8" > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > t/db_dependent/Reports_Guided.t | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) > >diff --git a/t/db_dependent/Reports_Guided.t b/t/db_dependent/Reports_Guided.t >index 4e2041a5..9c4a93d 100755 >--- a/t/db_dependent/Reports_Guided.t >+++ b/t/db_dependent/Reports_Guided.t >@@ -17,7 +17,8 @@ > > use Modern::Perl; > >-use Test::More tests => 16; >+use Test::More tests => 17; >+use Test::Warn; > > use C4::Context; > >@@ -100,11 +101,11 @@ is_deeply( > # for next test, we want to let execute_query capture any SQL errors > $dbh->{RaiseError} = 0; > my $errors; >-($sth, $errors) = execute_query( >- 'SELECT surname FRM borrowers', # error in the query is intentional >- 0, >- 10, >-); >+warning_like { ($sth, $errors) = execute_query( >+ 'SELECT surname FRM borrowers', # error in the query is intentional >+ 0, 10 ) } >+ qr/^DBD::mysql::st execute failed: You have an error in your SQL syntax;/, >+ "Wrong SQL syntax raises warning"; > ok( > defined($errors) && exists($errors->{queryerr}), > 'attempting to run a report with an SQL syntax error returns error message (Bug 12214)' >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11672
:
27955
|
31125
|
31126
|
31187
|
31188
|
31189
|
31190
|
31808
|
31809
|
31810