From: D Ruth Bavousett To: dev@bywatersolutions.com Cc: D Ruth Bavousett Subject: [PATCH] Bug 5230: Call number ranges in export don't give expected results. Date: Thu, 10 Feb 2011 21:01:14 -0500 Message-Id: <1297389674-2671-1-git-send-email-ruth@bywatersolutions.com> X-Mailer: git-send-email 1.5.6.5 X-Original-Sender: ruth@bywatersolutions.com X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 72.96.176.230 is neither permitted nor denied by best guess record for domain of dev01@drb) smtp.mail=dev01@drb Precedence: list Mailing-list: list dev@bywatersolutions.com; contact dev+owners@bywatersolutions.com List-ID: List-Help: , If you entered low number and high number, you got only items that *exactly* matched either entry (if any). If you enter only a low number, you got everying *lower* than that. If you enter only a high number, you get everything *higher* than that. This was a greater-than-less-than problem. --- tools/export.pl | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/export.pl b/tools/export.pl index a1e9a22..4d23d08 100755 --- a/tools/export.pl +++ b/tools/export.pl @@ -101,12 +101,12 @@ if ($op eq "export") { } if ( $start_callnumber ) { - $query .= " AND biblioitems.biblionumber = items.biblionumber AND itemcallnumber <= ? "; + $query .= " AND biblioitems.biblionumber = items.biblionumber AND itemcallnumber >= ? "; push @sql_params, $start_callnumber; } if ( $end_callnumber ) { - $query .= " AND biblioitems.biblionumber = items.biblionumber AND itemcallnumber >= ? "; + $query .= " AND biblioitems.biblionumber = items.biblionumber AND itemcallnumber <= ? "; push @sql_params, $end_callnumber; } if ( $start_accession ) { -- 1.5.6.5