From 6ce99154603c9a835a7c975d8262a346ea0f0b22 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marc=20V=C3=A9ron?= Date: Wed, 3 Sep 2014 12:10:26 +0200 Subject: [PATCH] [SIGNED-OFF] Bug 12863 - News in OPAC: HTML broken with nested p tags and multiple thead in same table Content-Type: text/plain; charset="utf-8" This patch fixes broken HTML in OPAC news by replacing table display with divs. To test: Create multiple news for OPAC Validate with HTML validator or check source code Result: Error with nested p tags Table header thead is repeated for every news (not allowed) Bonus testing: Let a screen reader like NVDA read the news and try to understand it with closed eyes. Apply patch Result: No more HTML errors in news Screen reader reads news properly To style you can use classes newscontainer, newsitem, newsheader, newsbody and newsfooter. Signed-off-by: Owen Leonard --- .../opac-tmpl/bootstrap/en/modules/opac-main.tt | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt index 450506e..83835c7 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt @@ -38,14 +38,14 @@ [% END %] [% IF ( koha_news_count ) %] -
- - [% FOREACH koha_new IN koha_news %] - - - [% END %] -
[% koha_new.title %]

[% koha_new.new %]

-

(published on [% koha_new.newdate %])

+
+ [% FOREACH koha_new IN koha_news %] +
+

[% koha_new.title %]

+
[% koha_new.new %]
+
(published on [% koha_new.newdate %])
+
+ [% END %]
[% END %] -- 1.7.9.5