Bugzilla – Attachment 31439 Details for
Bug 12811
Patron 'Details' and 'Check out' pages not working properly for staff users which don't have renewal override permissions
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 12811 - Patron 'Details' and 'Check out' pages not working for staff users without renewal override permissions
PASSED-QA-Bug-12811---Patron-Details-and-Check-out.patch (text/plain), 3.28 KB, created by
Katrin Fischer
on 2014-09-07 21:08:23 UTC
(
hide
)
Description:
[PASSED QA] Bug 12811 - Patron 'Details' and 'Check out' pages not working for staff users without renewal override permissions
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2014-09-07 21:08:23 UTC
Size:
3.28 KB
patch
obsolete
>From 9cb432c6a752d320fc03d19820d9fe2b48e50a73 Mon Sep 17 00:00:00 2001 >From: Jacek Ablewicz <abl@biblos.pk.edu.pl> >Date: Sat, 23 Aug 2014 16:36:21 +0200 >Subject: [PATCH] [PASSED QA] Bug 12811 - Patron 'Details' and 'Check out' > pages not working for staff users without renewal override permissions > >In case when the staff user doesn't have (circulate) -> >(override_renewals) permission granted, this code part > > var AllowRenewalLimitOverride = [% >CAN_user_circulate_override_renewals && AllowRenewalLimitOverride %]; > >in circ/circulation.tt and members/moremember.tt leads to javascript >error, because TT statement evaluates to empty string. > >To reproduce: > >- set AllowRenewalLimitOverride syspref to "Don't allow" (this step is > possibly redundant / not quite relevant), >- for testing purposes, log in as some (sample) staff user whitch does > not have permission granted for "(override_renewals) Override blocked > renewals", >- have a look at some patron accounts (preferably, ones with 1+ > check-out), observe that page layout is incorrect in "Check Out" and > "Details" tab. > >To test: > >- apply patch, >- retest and ensure that this issue is no longer reproductible, >- make sure that there are no regressions of any kinds regarding renewal > override permission for staff users (i.e, that it still works like > intended). > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Works as described, passes QA script and tests. >--- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >index 9734c0f..2838138 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >@@ -32,7 +32,7 @@ var theme = "[% theme %]"; > var borrowernumber = "[% borrowernumber %]"; > var branchcode = "[% branch %]"; > var exports_enabled = "[% exports_enabled %]"; >-var AllowRenewalLimitOverride = [% CAN_user_circulate_override_renewals && AllowRenewalLimitOverride %]; >+var AllowRenewalLimitOverride = [% (CAN_user_circulate_override_renewals && AllowRenewalLimitOverride)? 1: 0 %]; > var relatives_borrowernumbers = new Array(); > [% FOREACH b IN relatives_borrowernumbers %] > relatives_borrowernumbers.push("[% b %]"); >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt >index 8b3fbdd..794e383 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt >@@ -26,7 +26,7 @@ var theme = "[% theme %]"; > var borrowernumber = "[% borrowernumber %]"; > var branchcode = "[% branch %]"; > var exports_enabled = "[% exports_enabled %]"; >-var AllowRenewalLimitOverride = [% CAN_user_circulate_override_renewals && AllowRenewalLimitOverride %]; >+var AllowRenewalLimitOverride = [% (CAN_user_circulate_override_renewals && AllowRenewalLimitOverride)? 1: 0 %]; > var relatives_borrowernumbers = new Array(); > [% FOREACH b IN relatives_borrowernumbers %] > relatives_borrowernumbers.push("[% b %]"); >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12811
:
31123
|
31197
| 31439