From de7df88193e4ae764eaa66efc19e2bdc0f453a3e Mon Sep 17 00:00:00 2001 From: Olli-Antti Kivilahti Date: Mon, 15 Sep 2014 11:42:34 +0300 Subject: [PATCH] Bug 12923 - Improve error logging for advance_notices.pl; Show borrowernumber when no letter of type is found and force utf8 output. --- misc/cronjobs/advance_notices.pl | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/misc/cronjobs/advance_notices.pl b/misc/cronjobs/advance_notices.pl index 26f87ae..5581b8d 100755 --- a/misc/cronjobs/advance_notices.pl +++ b/misc/cronjobs/advance_notices.pl @@ -161,6 +161,8 @@ The F program allows you to send messages to patrons when their messages are overdue. =cut +binmode( STDOUT, ':encoding(UTF-8)' ); + # These are defaults for command line options. my $confirm; # -c: Confirm that the user has read and configured this script. my $nomail; # -n: No mail. Will not send any emails. @@ -265,7 +267,7 @@ UPCOMINGITEM: foreach my $upcoming ( @$upcoming_dues ) { substitute => { 'items.content' => $titles }, message_transport_type => $transport, } ) - or warn "no letter of type '$letter_type' found. Please see sample_notices.sql"; + or warn "no letter of type '$letter_type' found for borrowernumber ".$upcoming->{'borrowernumber'}.". Please see sample_notices.sql"; push @letters, $letter if $letter; } } @@ -301,7 +303,7 @@ UPCOMINGITEM: foreach my $upcoming ( @$upcoming_dues ) { substitute => { 'items.content' => $titles }, message_transport_type => $transport, } ) - or warn "no letter of type '$letter_type' found. Please see sample_notices.sql"; + or warn "no letter of type '$letter_type' found for borrowernumber ".$upcoming->{'borrowernumber'}.". Please see sample_notices.sql"; push @letters, $letter if $letter; } } @@ -376,7 +378,7 @@ PATRON: while ( my ( $borrowernumber, $digest ) = each %$upcoming_digest ) { message_transport_type => $transport, } ) - or warn "no letter of type '$letter_type' found. Please see sample_notices.sql"; + or warn "no letter of type '$letter_type' found for borrowernumber $borrowernumber. Please see sample_notices.sql"; push @letters, $letter if $letter; } @@ -434,7 +436,7 @@ PATRON: while ( my ( $borrowernumber, $digest ) = each %$due_digest ) { message_transport_type => $transport, } ) - or warn "no letter of type '$letter_type' found. Please see sample_notices.sql"; + or warn "no letter of type '$letter_type' found for borrowernumber $borrowernumber. Please see sample_notices.sql"; push @letters, $letter if $letter; } -- 1.7.9.5