From 32ee00e8ba86ccc508c4431ecc022b5fd0995d48 Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Fri, 5 Sep 2014 12:41:20 -0300 Subject: [PATCH] Bug 12879: Remove unnecesary diags from Holds.t There are two unnecessary diag statements: - Creating biblio instance for testing. - Creating item instance for testing. TEST PLAN --------- 1) prove t/db_dependent/Holds.t t/db_dependent/Holds.t .. 1/38 # Creating biblio instance for testing. Use of uninitialized value in subroutine entry at /home/tcohen/git/koha-community-src/C4/Charset.pm line 181. # Creating item instance for testing. Use of uninitialized value in subroutine entry at /home/tcohen/git/koha-community-src/C4/Charset.pm line 181. Use of uninitialized value in subroutine entry at /home/tcohen/git/koha-community-src/C4/Charset.pm line 181. t/db_dependent/Holds.t .. ok All tests successful. Files=1, Tests=38, 1 wallclock secs ( 0.03 usr 0.01 sys + 1.13 cusr 0.11 csys = 1.28 CPU) Result: PASS -- They are in the first and fourth lines of this sample output 2) apply patch 3) prove t/db_dependent/Holds.t t/db_dependent/Holds.t .. 1/38 Use of uninitialized value in subroutine entry at /home/mtompset/kohaclone/C4/Charset.pm line 186. Use of uninitialized value in subroutine entry at /home/mtompset/kohaclone/C4/Charset.pm line 186. Use of uninitialized value in subroutine entry at /home/mtompset/kohaclone/C4/Charset.pm line 186. t/db_dependent/Holds.t .. ok All tests successful. Files=1, Tests=38, 1 wallclock secs ( 0.01 usr 0.00 sys + 0.78 cusr 0.09 csys = 0.88 CPU) Result: PASS -- They are no longer in the first and fourth lines of this sample output 4) run koha QA test tool Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart --- t/db_dependent/Holds.t | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/t/db_dependent/Holds.t b/t/db_dependent/Holds.t index b7bc547..ec969bb 100755 --- a/t/db_dependent/Holds.t +++ b/t/db_dependent/Holds.t @@ -35,12 +35,10 @@ $insert_sth->execute('CAN'); $insert_sth->execute('CANNOT'); # Setup Test------------------------ -# Helper biblio. -diag("Creating biblio instance for testing."); +# Create a biblio instance for testing my ($bibnum, $title, $bibitemnum) = create_helper_biblio(); -# Helper item for that biblio. -diag("Creating item instance for testing."); +# Create item instance for testing. my ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => 'CPL', holdingbranch => 'CPL' } , $bibnum); # Create some borrowers -- 2.1.0