Bugzilla – Attachment 31792 Details for
Bug 12916
Use of uninitialized values $max and $min in C4/Tags.pm
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 12916 - Use of uninitialized values $max and $min in C4/Tags.pm
Bug-12916---Use-of-uninitialized-values-max-and-mi.patch (text/plain), 1004 bytes, created by
Marc Véron
on 2014-09-20 18:29:46 UTC
(
hide
)
Description:
Bug 12916 - Use of uninitialized values $max and $min in C4/Tags.pm
Filename:
MIME Type:
Creator:
Marc Véron
Created:
2014-09-20 18:29:46 UTC
Size:
1004 bytes
patch
obsolete
>From eea865d36ca3674b8677107e5440b8dad7b18144 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Marc=20V=C3=A9ron?= <veron@veron.ch> >Date: Sat, 20 Sep 2014 20:20:10 +0200 >Subject: [PATCH] Bug 12916 - Use of uninitialized values $max and $min in > C4/Tags.pm > >Test plan: >Make sure that you have no tags >In Opac, go to 'Tag cloud' >Check opac-error.log for entries regarding uninitialized values $max and $min in C4/Tags.pm, line 600 >Apply patch >Reload page 'Tag cloud' >Result: No more warnings in opac-error.log >--- > C4/Tags.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Tags.pm b/C4/Tags.pm >index b6b319b..871dcd5 100644 >--- a/C4/Tags.pm >+++ b/C4/Tags.pm >@@ -589,7 +589,7 @@ sub add_tag { # biblionumber,term,[borrowernumber,approvernumber] > sub stratify_tags { > my ( $strata, $tags ) = @_; > >- my ( $min, $max ); >+ my ( $min, $max ) = ( 0, 0 ); > foreach (@$tags) { > my $w = $_->{weight_total}; > $min = $w if ( !defined($min) || $min > $w ); >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12916
:
31792
|
32590
|
32604
|
32605
|
32611
|
32612
|
32700
|
32701
|
32732
|
32733