Bugzilla – Attachment 3218 Details for
Bug 5805
Changing Pickup library on already queued holds causes havoc on all holds below it
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
patch
bug5805.patch (text/plain), 2.39 KB, created by
Nicole C. Engard
on 2011-02-25 13:40:12 UTC
(
hide
)
Description:
patch
Filename:
MIME Type:
Creator:
Nicole C. Engard
Created:
2011-02-25 13:40:12 UTC
Size:
2.39 KB
patch
obsolete
>From: ruth@bywatersolutions.com >To: dev@bywatersolutions.com >Cc: D Ruth Bavousett <ruth@bywatersolutions.com> >Subject: [PATCH] Bug 5805: Having items in-transit can cause derangement of the hold list >Date: Thu, 24 Feb 2011 21:50:49 -0500 >Message-Id: <1298602249-1835-1-git-send-email-ruth@bywatersolutions.com> >X-Mailer: git-send-email 1.7.2.3 >X-Original-Sender: ruth@bywatersolutions.com >X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: > 209.85.212.42 is neither permitted nor denied by best guess record for domain > of ruth@bywatersolutions.com) smtp.mail=ruth@bywatersolutions.com >X-Google-Group-Id: -607656515 >Precedence: list >Mailing-list: list dev@bywatersolutions.com; contact dev+owners@bywatersolutions.com >List-ID: <dev.bywatersolutions.com> >List-Help: <http://www.google.com/support/a/bywatersolutions.com/bin/static.py?hl=en_US&page=groups.cs>, > <mailto:dev+help@bywatersolutions.com> > >If you have a list of holds on a biblio, and one or more are in-transit, then the >array that is fed to modrequest.pl is not fully-populated, lacking the branch on the >in-transit rows. If you then attempt to edit one of the remaining holds' pickup >location, it doesn't modify the one you expect, but ones *above* that. Also, holds >at the bottom of the list get the first pickup library in the list, since they are >getting undef passed in. >--- > .../prog/en/modules/reserve/request.tmpl | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tmpl >index 58a5ad9..53ff7b7 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tmpl >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tmpl >@@ -639,7 +639,7 @@ function checkMultiHold() { > <!-- TMPL_IF name="found" --> > Item waiting at <b> <!-- TMPL_VAR NAME="wbrname" --></b> <input type="hidden" name="pickup" value="<!-- TMPL_VAR NAME="wbrcode" -->" /> > <!-- TMPL_ELSE --> >- Waiting to be pulled >+ Waiting to be pulled <input type="hidden" name="pickup" value="<!-- TMPL_VAR NAME="wbrcode" -->" /> > <!-- /TMPL_IF --> > <!-- TMPL_ELSE --> > Item being transferred to <b> <!-- TMPL_VAR NAME="wbrname" --></b> <input type="hidden" name="pickup" value="<!-- TMPL_VAR NAME="wbrcode" -->" /> >-- >1.7.2.3 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 5805
: 3218