From a57a72fa42c435a75c4d0d8580b4829cf758ab9c Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Fri, 10 Oct 2014 21:50:05 +0200 Subject: [PATCH] [PASSED QA] Bug 7673: add syspref in sysprefs.pl Also fix a typo in the permission description Signed-off-by: Katrin Fischer Patches pass QA script and tests. Copying the test plan from the bug report: Test plan: 1/ add the following permissions to the logged in patron: edit_item, edit_items_restricted, delete_all_items, items_batchmod, items_batchmod_restricted 2/ Fill the prefs SubfieldsToAllowForRestrictedEdition and SubfieldsToAllowForRestrictedBatchmod with some subfield (for instance "995$f 995$o" and "995$o") 3/ Verify you are allowed to edit the item fields defined in the pref SubfieldsToAllowForRestrictedEdition. 4/ Try to edit item in a batch and verify you are allowed to edit the item fields defined in the pref SubfieldsToAllowForRestrictedBatchmod. 5/ Try to delete all items of a record Play with the pref/permissions and verify they are correctly taken into account. --- installer/data/mysql/sysprefs.sql | 2 ++ installer/data/mysql/updatedatabase.pl | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql index b06b163..5c9a656 100644 --- a/installer/data/mysql/sysprefs.sql +++ b/installer/data/mysql/sysprefs.sql @@ -379,6 +379,8 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` ('StaffSerialIssueDisplayCount','3','','Number of serial issues to display per subscription in the Staff client','Integer'), ('StaticHoldsQueueWeight','0',NULL,'Specify a list of library location codes separated by commas -- the list of codes will be traversed and weighted with first values given higher weight for holds fulfillment -- alternatively, if RandomizeHoldsQueueWeight is set, the list will be randomly selective','Integer'), ('StatisticsFields','location|itype|ccode', NULL, 'Define Fields (from the items table) used for statistics members','Free'), +('SubfieldsToAllowForRestrictedBatchmod','','Define a list of subfields for which edition is authorized when items_batchmod_restricted permission is enabled, separated by spaces. Example: 995\$f 995\$h 995\$j',NULL,'Free'); +('SubfieldsToAllowForRestrictedEdition','','Define a list of subfields for which edition is authorized when edit_items_restricted permission is enabled, separated by spaces. Example: 995\$f 995\$h 995\$j',NULL,'Free'), ('SubfieldsToUseWhenPrefill','','','Define a list of subfields to use when prefilling items (separated by space)','Free'), ('SubscriptionDuplicateDroppedInput','','','List of fields which must not be rewritten when a subscription is duplicated (Separated by pipe |)','Free'), ('SubscriptionHistory','simplified','simplified|full','Define the display preference for serials issue history in OPAC','Choice'), diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl index 41428b8..9cd1016 100755 --- a/installer/data/mysql/updatedatabase.pl +++ b/installer/data/mysql/updatedatabase.pl @@ -8791,7 +8791,7 @@ if ( C4::Context->preference("Version") < TransformToNum($DBversion) ) { }); $dbh->do(q{ - INSERT INTO permissions (module_bit, code, description) VALUES ('13', 'items_batchmod_restricted', 'Limit batch item modification to subfields defined in the SubfieldsToAllowForRestrictedBatchmod preferenec (pplease note that items_batchmod is still required)'); + INSERT INTO permissions (module_bit, code, description) VALUES ('13', 'items_batchmod_restricted', 'Limit batch item modification to subfields defined in the SubfieldsToAllowForRestrictedBatchmod preference (please note that items_batchmod is still required)'); }); # The delete_all_items permission should be added to users having the edit_items permission. -- 1.9.1