Bugzilla – Attachment 32394 Details for
Bug 13084
Prevent mixup of columns in deletedborrowers
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13084 - Improve t/db_dependent/Members.t test coverage
Bug-13084---Improve-tdbdependentMemberst-test-cove.patch (text/plain), 1.56 KB, created by
Marcel de Rooy
on 2014-10-16 06:59:27 UTC
(
hide
)
Description:
Bug 13084 - Improve t/db_dependent/Members.t test coverage
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2014-10-16 06:59:27 UTC
Size:
1.56 KB
patch
obsolete
>From f8e4e4063edc0f6faaddd63a8afb5d9398a5c143 Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Wed, 15 Oct 2014 18:18:46 -0400 >Subject: [PATCH] Bug 13084 - Improve t/db_dependent/Members.t test coverage >Content-Type: text/plain; charset=utf-8 > >Added a MoveMemberToDeleted set of tests. > >TEST PLAN >--------- >1) prove -v t/db_dependent/Members.t > -- all should pass. >2) Run koha QA tests. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > t/db_dependent/Members.t | 16 +++++++++++++++- > 1 files changed, 15 insertions(+), 1 deletions(-) > >diff --git a/t/db_dependent/Members.t b/t/db_dependent/Members.t >index 592c463..998320b 100755 >--- a/t/db_dependent/Members.t >+++ b/t/db_dependent/Members.t >@@ -17,7 +17,7 @@ > > use Modern::Perl; > >-use Test::More tests => 56; >+use Test::More tests => 58; > use Test::MockModule; > use Data::Dumper; > use C4::Context; >@@ -85,6 +85,20 @@ my %data = ( > my $addmem=AddMember(%data); > ok($addmem, "AddMember()"); > >+# It's not really a Move, it's a Copy. >+my $result = MoveMemberToDeleted($addmem); >+ok($result,"MoveMemberToDeleted()"); >+ >+my $sth = $dbh->prepare("SELECT * from borrowers WHERE borrowernumber=?"); >+$sth->execute($addmem); >+my $MemberAdded = $sth->fetchrow_hashref; >+ >+$sth = $dbh->prepare("SELECT * from deletedborrowers WHERE borrowernumber=?"); >+$sth->execute($addmem); >+my $MemberMoved = $sth->fetchrow_hashref; >+ >+is_deeply($MemberMoved,$MemberAdded,"Confirm MoveMemberToDeleted."); >+ > my $member=GetMemberDetails("",$CARDNUMBER) > or BAIL_OUT("Cannot read member with card $CARDNUMBER"); > >-- >1.7.7.6
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13084
:
32343
|
32344
|
32378
|
32379
|
32380
|
32381
|
32394
|
32395
|
32396
|
32397
|
32490
|
32491
|
32492
|
32493
|
32494
|
32495
|
32496
|
32497
|
32500
|
32501
|
32502