From 56ecda483028fc302934f05b138bdb00899a2b8e Mon Sep 17 00:00:00 2001 From: Mark Tompsett Date: Wed, 22 Oct 2014 15:50:08 -0400 Subject: [PATCH] Bug 12916 - Missing Test to demonstrate warnings. Modifying C4/Tags.pm should have tests. TEST PLAN --------- 1) Apply this test patch only. 2) prove -v t/db_dependent/Tags.t -- should see two warnings. 3) Apply the first patch. 4) prove -v t/db_dependent/Tags.t -- no warnings. --- t/db_dependent/Tags.t | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/t/db_dependent/Tags.t b/t/db_dependent/Tags.t index 5359e30..035ce72 100755 --- a/t/db_dependent/Tags.t +++ b/t/db_dependent/Tags.t @@ -6,16 +6,23 @@ use strict; use warnings; -use Test::More tests => 30; +use Test::More tests => 34; BEGIN { use_ok('C4::Tags'); } +# Check no tags case. +my @tagsarray; +my $tags = \@tagsarray; +my ($min, $max) = C4::Tags::stratify_tags(0, $tags); +is($min, 0, 'Empty array min'); +is($max, 0, 'Empty array max'); + # Simple 'sequential 5' test -my $tags = make_tags(1,2,3,4,5); +$tags = make_tags(1,2,3,4,5); my @strata = (0,1,2,3,4); -my ($min, $max) = C4::Tags::stratify_tags(5, $tags); +($min, $max) = C4::Tags::stratify_tags(5, $tags); check_tag_strata($tags, \@strata, 'Sequential 5'); is($min, 0, 'Sequential 5 min'); is($max, 4, 'Sequential 5 max'); -- 1.7.9.5