Bugzilla – Attachment 3299 Details for
Bug 5864
Is C4::Serials::GetSubscriptions searching too generally?
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch from BibLibre
0001-Bug-5864-link-biblio-serials-subscription-is-wrong.patch (text/plain), 3.23 KB, created by
Julian Maurice
on 2011-03-15 08:18:24 UTC
(
hide
)
Description:
Patch from BibLibre
Filename:
MIME Type:
Creator:
Julian Maurice
Created:
2011-03-15 08:18:24 UTC
Size:
3.23 KB
patch
obsolete
>From c316409cbd19e3b2e2669fe3fd6a17f908a936dc Mon Sep 17 00:00:00 2001 >From: Julian Maurice <julian.maurice@biblibre.com> >Date: Tue, 15 Mar 2011 09:04:40 +0100 >Subject: [PATCH] Bug 5864: link biblio => serials subscription is wrong > >The GetSubscription function can be called with 3 parameters : title, >issn, biblionumber. >In biblio view (both opac & staff interface), the link to jump from the >biblio to the subscription(s) was done using title. > >The result was that for a title like "Science", all subscriptions >containing "science" in the title were linked. >That's too much and that's false. > >This commit fixes this problem by calling GetSubscription with >biblionumber only where applicable. >--- > .../prog/en/includes/biblio-view-menu.inc | 2 +- > opac/opac-ISBDdetail.pl | 4 ++-- > opac/opac-detail.pl | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc >index 97b642f..123e71c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc >@@ -24,7 +24,7 @@ > <!-- TMPL_IF NAME="holdsview" --><li class="active"><!-- TMPL_ELSE --><li><!-- /TMPL_IF --><a href="/cgi-bin/koha/reserve/request.pl?biblionumber=<!-- TMPL_IF NAME="object" --><!-- TMPL_VAR NAME="object" --><!-- TMPL_ELSE --><!-- TMPL_VAR NAME="biblionumber" --><!-- /TMPL_IF -->">Holds</a></li> > <!-- /TMPL_IF --> > >- <!-- TMPL_IF name="subscriptionsnumber" --><li><a href="/cgi-bin/koha/serials/serials-home.pl?searched=1&title_filter=<!-- TMPL_VAR NAME="subscriptiontitle" -->">Subscription(s)</a></li><!-- /TMPL_IF --> >+ <!-- TMPL_IF name="subscriptionsnumber" --><li><a href="/cgi-bin/koha/serials/serials-home.pl?searched=1&biblionumber=<!-- TMPL_VAR NAME="biblionumber" -->">Subscription(s)</a></li><!-- /TMPL_IF --> > </ul> > <ul> > <!-- TMPL_IF NAME="issuehistoryview" --><li class="active"><!-- TMPL_ELSE --><li><!-- /TMPL_IF --> >diff --git a/opac/opac-ISBDdetail.pl b/opac/opac-ISBDdetail.pl >index e022497..baf48c1 100755 >--- a/opac/opac-ISBDdetail.pl >+++ b/opac/opac-ISBDdetail.pl >@@ -97,8 +97,8 @@ $template->param( > my $subscriptionsnumber = CountSubscriptionFromBiblionumber($biblionumber); > my $dbh = C4::Context->dbh; > my $dat = TransformMarcToKoha( $dbh, $record ); >-my @subscriptions = >- GetSubscriptions( $dat->{title}, $dat->{issn}, $biblionumber ); >+my @subscriptions = GetSubscriptions( undef, undef, $biblionumber ); >+ > my @subs; > foreach my $subscription (@subscriptions) { > my %cell; >diff --git a/opac/opac-detail.pl b/opac/opac-detail.pl >index 93edc15..00f0fe1 100755 >--- a/opac/opac-detail.pl >+++ b/opac/opac-detail.pl >@@ -101,7 +101,7 @@ my $collections = GetKohaAuthorisedValues('items.ccode',$dat->{'frameworkcode'} > > #coping with subscriptions > my $subscriptionsnumber = CountSubscriptionFromBiblionumber($biblionumber); >-my @subscriptions = GetSubscriptions( $dat->{title}, $dat->{issn}, $biblionumber ); >+my @subscriptions = GetSubscriptions( undef, undef, $biblionumber ); > > my @subs; > $dat->{'serial'}=1 if $subscriptionsnumber; >-- >1.7.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 5864
: 3299