From 0d2b490c1f3cfc77f5261bc5eea82bdd01328547 Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Wed, 29 Oct 2014 16:24:49 -0300 Subject: [PATCH] [PASSED QA] Bug 13164: Incorrect ISSN visualization on the normal view if invalid/cancelled ISSN present Currently, 022$z (and 011$z for UNIMARC) occurences are not shown, but the XSLT logic used introduces punctuation characters for those $z occurences. This patch adds a check for the existence of subfield a, and only loops on $a subfields. To test: - Create/have a record with 022$z (or 011$z on UNIMARC) but no 022$a (no 011$a on UNIMARC). - Open the detail page for the record (on both OPAC and staff). => FAIL: the ISSN label and ';' and '.' characters incorrectly shown. - Repeat mixing with 022$a occurences to notice the bug. - Apply the patch, reload => SUCCES: ISSN label shows only on the presence of a $a, and $z are skipped. no matter how many ISSN fields you add. - Sign off :-D Regards To+ Signed-off-by: Frederic Demians Works as described on an UNIMARC DB. Mimics what's done for ISBN field. Signed-off-by: Kyle M Hall --- .../prog/en/xslt/MARC21slim2intranetDetail.xsl | 24 ++++++++++++----- .../prog/en/xslt/NORMARCslim2intranetDetail.xsl | 24 ++++++++++++----- .../prog/en/xslt/UNIMARCslim2intranetDetail.xsl | 27 ++++++++++-------- .../bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 24 ++++++++++++----- .../bootstrap/en/xslt/NORMARCslim2OPACDetail.xsl | 24 ++++++++++++----- .../bootstrap/en/xslt/UNIMARCslim2OPACDetail.xsl | 28 ++++++++++--------- 6 files changed, 98 insertions(+), 53 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl index e7bf6d1..6711f9d 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl +++ b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl @@ -400,13 +400,23 @@ - - ISSN: - - - .; - - + + + ISSN: + + + + + + . + + + ; + + + + + diff --git a/koha-tmpl/intranet-tmpl/prog/en/xslt/NORMARCslim2intranetDetail.xsl b/koha-tmpl/intranet-tmpl/prog/en/xslt/NORMARCslim2intranetDetail.xsl index 3271e5b..150a29a 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/xslt/NORMARCslim2intranetDetail.xsl +++ b/koha-tmpl/intranet-tmpl/prog/en/xslt/NORMARCslim2intranetDetail.xsl @@ -316,13 +316,23 @@ - - ISSN: - - - .; - - + + + ISSN: + + + + + + . + + + ; + + + + + diff --git a/koha-tmpl/intranet-tmpl/prog/en/xslt/UNIMARCslim2intranetDetail.xsl b/koha-tmpl/intranet-tmpl/prog/en/xslt/UNIMARCslim2intranetDetail.xsl index 552385e..61d8085 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/xslt/UNIMARCslim2intranetDetail.xsl +++ b/koha-tmpl/intranet-tmpl/prog/en/xslt/UNIMARCslim2intranetDetail.xsl @@ -159,19 +159,22 @@ - + +
  • - ISSN: - - - - - . - - - ; - - + ISSN: + + + + + + . + + + ; + + +
  • diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl index 15960cd..e51c088 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl +++ b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl @@ -440,13 +440,23 @@
    - - ISSN: - - - .; - - + + + ISSN: + + + + + + . + + + ; + + + + + diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/NORMARCslim2OPACDetail.xsl b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/NORMARCslim2OPACDetail.xsl index 62e004d..7a8e5ce 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/NORMARCslim2OPACDetail.xsl +++ b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/NORMARCslim2OPACDetail.xsl @@ -352,13 +352,23 @@ - - ISSN: - - - .; - - + + + ISSN: + + + + + + . + + + ; + + + + + diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslim2OPACDetail.xsl b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslim2OPACDetail.xsl index f7d1984..40eac3a 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslim2OPACDetail.xsl +++ b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslim2OPACDetail.xsl @@ -207,19 +207,21 @@ - - - ISSN: - - - - - . - - - ; - - + + + ISSN: + + + + + + . + + + ; + + + -- 1.7.2.5