From d798dbe66c4f787e82a9bc30815360bea88b0a10 Mon Sep 17 00:00:00 2001 From: Mark Tompsett Date: Wed, 5 Nov 2014 03:06:42 -0500 Subject: [PATCH] Bug 13200 - Followup of Bug 12246 - noisy C4/Auth.pm While testing a bug, warnings in the opac error log were building up due to a particular line in C4::Auth. After reviewing the code, it was discovered that removal of the OpacMainUserBlockMobile system preference created this. Since the system preference no longer exists, and is not used, the line was deleted from C4/Auth.pm to prevent this warning from occuring. TEST PLAN ---------- 1) Go to any OPAC page. 2) Check your opac error log. -- there should be something about uninitialized values used in C4/Auth.pm around line 443. 3) Apply the patch 4) Refresh the page. -- that same error should not be triggered. 5) prove -v t/db_dependent/Auth.t -- this runs the get_template_and_user function which had the parameter removed. 6) run the koha qa test tools --- C4/Auth.pm | 1 - 1 file changed, 1 deletion(-) diff --git a/C4/Auth.pm b/C4/Auth.pm index c6dda85..16d3ec2 100644 --- a/C4/Auth.pm +++ b/C4/Auth.pm @@ -467,7 +467,6 @@ sub get_template_and_user { OpacCloud => C4::Context->preference("OpacCloud"), OpacKohaUrl => C4::Context->preference("OpacKohaUrl"), OpacMainUserBlock => "" . C4::Context->preference("OpacMainUserBlock"), - OpacMainUserBlockMobile => "" . C4::Context->preference("OpacMainUserBlockMobile"), OpacNav => "" . C4::Context->preference("OpacNav"), OpacNavRight => "" . C4::Context->preference("OpacNavRight"), OpacNavBottom => "" . C4::Context->preference("OpacNavBottom"), -- 1.7.9.5