Bugzilla – Attachment 34293 Details for
Bug 12404
CSV profiles improvements (concatenations, substrings, conditions...)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 12123 - [Alternative patch] HTML notices can break the notice viewer
Bug-12123---Alternative-patch-HTML-notices-can-bre.patch (text/plain), 2.05 KB, created by
Biblibre Sandboxes
on 2014-12-11 09:03:52 UTC
(
hide
)
Description:
Bug 12123 - [Alternative patch] HTML notices can break the notice viewer
Filename:
MIME Type:
Creator:
Biblibre Sandboxes
Created:
2014-12-11 09:03:52 UTC
Size:
2.05 KB
patch
obsolete
>From 179b589f4efdff82a500fcdedb6d4ee65b16d58d Mon Sep 17 00:00:00 2001 >From: Liz Rea <liz@catalyst.net.nz> >Date: Tue, 25 Nov 2014 12:03:50 +1300 >Subject: [PATCH] Bug 12123 - [Alternative patch] HTML notices can break the notice viewer > >Depending on the content of an html notice, it can cause the notice to >either not be collapsible, be uncollapsible, or to be permanently >collapsed. > >Test Plan: >1) Set your CHECKOUT notice to the following ( with HTML Message checked ) : ><p>The following items have been checked out:</p> > >---- ><blockquote> <<biblio.title>> </blockquote> >---- > ><p>Thank you for visiting the <<branches.branchname>> of HMCPL.</p> >2) Check out some items to a patron >3) View the patrn's notices >4) Note the notice viewer is broken ( message is not collapsed, and > con't be collapsed ). >5) Apply this patch >6) Reload the page >7) Note the notice viewer is no longer broken > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >This patch appears to fix the problem with the minimum required change. > >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Works nicely, no problems found. >Passes tests and QA script. > >Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> > >Signed-off-by: scourret@gmail.com <2> > >http://bugs.koha-community.org/show_bug.cgi?id=12404 >--- > .../prog/en/modules/members/notices.tt | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt >index 31d40ba..50c7d0e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt >@@ -55,9 +55,9 @@ > <tr> > <td> > <a class="notice-title" href="#">[% QUEUED_MESSAGE.subject %]</a> >- <p class="notice"> >+ <div class="notice"> > [% QUEUED_MESSAGE.content FILTER html_line_break %] >- </p> >+ </div> > </td> > <td> > [% IF ( QUEUED_MESSAGE.message_transport_type == 'email' ) %]email >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12404
:
28767
|
28768
|
28769
|
28770
|
28771
|
33170
|
33171
|
33172
|
33173
|
33174
|
33263
|
33477
|
34288
|
34289
|
34290
|
34291
|
34292
|
34293
|
34294
|
34300
|
34301
|
34302
|
34303
|
34405
|
34406
|
34407
|
34408
|
34409
|
34410
|
34411
|
35048
|
35049
|
35050
|
35051
|
35052
|
35053
|
35054