Bugzilla – Attachment 3450 Details for
Bug 5870
Enhancements to suggestions management
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Followup patch
0002-Bug-5870-Follow-up-clean-up-patch.patch (text/plain), 1.76 KB, created by
Chris Cormack
on 2011-03-28 01:34:24 UTC
(
hide
)
Description:
Followup patch
Filename:
MIME Type:
Creator:
Chris Cormack
Created:
2011-03-28 01:34:24 UTC
Size:
1.76 KB
patch
obsolete
>From 972c195db34605eada3f58d686e3d07066f73cfa Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?St=C3=A9phane=20Delaune?= <stephane.delaune@biblibre.com> >Date: Fri, 24 Sep 2010 17:02:48 +0200 >Subject: [PATCH] Bug 5870 : Follow up clean up patch > >(MT #4626) followup debug suggestion management : "accepted by" was not correctly displayed on suggestion's edit page > > suggestion's status, document's type and "accepted by" was not correctly displayed on suggestion's edit page > (link with MT #4585) >--- > suggestion/suggestion.pl | 17 ++++++++++++----- > 1 files changed, 12 insertions(+), 5 deletions(-) > >diff --git a/suggestion/suggestion.pl b/suggestion/suggestion.pl >index 4ce0cef..ccb6bda 100755 >--- a/suggestion/suggestion.pl >+++ b/suggestion/suggestion.pl >@@ -99,11 +99,18 @@ my ( $template, $borrowernumber, $cookie ) = get_template_and_user( > ######################################### > ## Operations > ## >-if ($op =~/save/i){ >- if ($$suggestion_ref{'suggestionid'}>0){ >- &ModSuggestion($suggestion_ref); >- } >- else { >+if ( $op =~ /save/i ) { >+ if ( $$suggestion_ref{"STATUS"} ) { >+ if ( my $tmpstatus = lc( $$suggestion_ref{"STATUS"} ) =~ /ACCEPTED|REJECTED/i ) { >+ $$suggestion_ref{ lc( $$suggestion_ref{"STATUS"}) . "date" } = C4::Dates->today; >+ $$suggestion_ref{ lc( $$suggestion_ref{"STATUS"}) . "by" } = C4::Context->userenv->{number}; >+ } >+ $$suggestion_ref{"manageddate"} = C4::Dates->today; >+ $$suggestion_ref{"managedby"} = C4::Context->userenv->{number}; >+ } >+ if ( $$suggestion_ref{'suggestionid'} > 0 ) { >+ &ModSuggestion($suggestion_ref); >+ } else { > ###FIXME:Search here if suggestion already exists. > my $suggestions_loop = > SearchSuggestion( $suggestion_ref ); >-- >1.7.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 5870
:
3308
| 3450