From c91c70a1315b24461036b7b13c8002122a2cf52a Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Mon, 15 Dec 2014 14:10:56 +0100 Subject: [PATCH] Bug 9743: Allow customization for making hold notes required Content-Type: text/plain; charset=utf-8 This patch removes some unused code in the reserves template for mandatory hold notes reasons. It adds a simpler approach: if you define a custom routine for required hold notes, the textarea is required under the conditions you specified. Test plan: [1] Without adding a routine in opac-reserve: Place a hold on one and on more biblio numbers. Verify that hold notes are not required in any case. [2] Add the following simple routine to opac-reserve: sub _reqholdnotes { 1; } Verify that hold notes are always required now. [3] Place a multiple hold request and check the following: If you hide the hold notes (and leave them blank), the additional options (incl. hold notes) should expand again for the first biblio with required hold notes when submitting the form. --- .../opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 37 +++++++++---------- opac/opac-reserve.pl | 5 ++- 2 files changed, 22 insertions(+), 20 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt index 6558e6e..e986911 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt @@ -235,10 +235,11 @@ [% IF ( OpacHoldNotes ) %]
  • - - - - + + [% IF bibitemloo.reqholdnotes %] + Please enter additional information on the part/volume/serial issue you request: + [% END %] +
  • [% END # / IF OpacHoldNotes %] @@ -403,10 +404,6 @@