Bugzilla – Attachment 35210 Details for
Bug 13579
History file should be open using utf-8 encoding
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13579: Prefer like instead of ok to match a regex
Bug-13579-Prefer-like-instead-of-ok-to-match-a-reg.patch (text/plain), 1.27 KB, created by
Jonathan Druart
on 2015-01-14 15:11:22 UTC
(
hide
)
Description:
Bug 13579: Prefer like instead of ok to match a regex
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2015-01-14 15:11:22 UTC
Size:
1.27 KB
patch
obsolete
>From c2058ef23c3befeea294f20bc2c437ec316c1b61 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Wed, 14 Jan 2015 16:08:11 +0100 >Subject: [PATCH] Bug 13579: Prefer like instead of ok to match a regex > >Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> >--- > t/db_dependent/www/history.t | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/www/history.t b/t/db_dependent/www/history.t >index 55748c7..0ad9c94 100644 >--- a/t/db_dependent/www/history.t >+++ b/t/db_dependent/www/history.t >@@ -61,7 +61,7 @@ my $encoded_latin_name = Encode::encode('UTF-8', 'Frédéric Demians'); > my $encoded_cyrillic_name = Encode::encode('UTF-8', 'СеÑгÑй ÐÑбик'); > my $history_page = Encode::encode('UTF-8', $agent->text()); > >-ok( $history_page =~ m/$encoded_latin_name/, "Latin characters with umlauts show correctly on the history page." ); >-ok( $history_page =~ m/$encoded_cyrillic_name/, "Cyrillic characters with umlauts show correctly on the history page." ); >+like( $history_page, qr/$encoded_latin_name/, "Latin characters with umlauts show correctly on the history page." ); >+like( $history_page, qr/$encoded_cyrillic_name/, "Cyrillic characters with umlauts show correctly on the history page." ); > > 1; >-- >2.1.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13579
:
35184
|
35185
|
35186
|
35195
|
35209
| 35210